-
Notifications
You must be signed in to change notification settings - Fork 547
feat: add project template with uv package manager
#1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,21 @@ | ||
| # % if cookiecutter.package_manager == 'poetry' | ||
| # % if cookiecutter.package_manager in ['poetry', 'uv'] | ||
| import subprocess | ||
| import re | ||
|
|
||
| manager = "{{cookiecutter.package_manager}}" | ||
| manager_text = manager.title() | ||
| # % if cookiecutter.package_manager == 'poetry' | ||
| version_regex = r'Poetry \(version 2\..*\)' | ||
| r_version = '2.x' | ||
| # % elif cookiecutter.package_manager == 'uv' | ||
| version_regex = r'uv (0\..*)' | ||
| r_version = '0.x' | ||
| # % endif | ||
|
|
||
| try: | ||
| version = subprocess.check_output(['poetry', '--version']).decode().strip() | ||
| version = subprocess.check_output([manager, '--version']).decode().strip() | ||
| except OSError as exc: | ||
| raise RuntimeError('You chose to use the Poetry package manager, but it does not seem to be installed') from exc | ||
|
|
||
| if not re.match(r'Poetry \(version 2\..*\)', version): | ||
| raise RuntimeError(f'Poetry 2.x is required, but "{version}" is installed') | ||
| raise RuntimeError(f'You chose to use the {manager_text} package manager, but it does not seem to be installed') from exc | ||
| if not re.match(version_regex, version): | ||
| raise RuntimeError(f'{manager_text} {r_version} is required, but "{version}" is installed') | ||
| # % endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I follow, so I will think aloud:
This is here because we might already have some version of
playwrightinstalled in the base image in location "/usr/local". When we do, we exclude it fromuv sync-> which btw syncs to where the python installation lives (so no isolated environment, but isolation is the image - so who cares).If there is specific playwright version requirement(probably just theoretical use case) - we will ignore it and take whatever version already exists in the base image.
Is my understanding correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right,
playwrightmay already be installed in the standardFROM apify/actor-python-playwrightimage.This is similar to the logic used in
poetry, but keeping the features thatuvprovides