Skip to content

feat: Use fingerprint generator in PlaywrightCrawler by default #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pijukatel merged 8 commits into from
Mar 7, 2025
Merged

feat: Use fingerprint generator in PlaywrightCrawler by default #1060

Pijukatel merged 8 commits into from
Mar 7, 2025

Conversation

@Pijukatel
Copy link
Collaborator

@Pijukatel Pijukatel commented Mar 7, 2025 •
edited
Loading

Description

PlaywrightCrawler uses fingerprint generator by default.
Default introduced to distinguish between:

  • None - in the meaning of do not use fingerprint generator.
  • Default - in the meaning of use default fingerprint generator. (Mutable argument, so the default should not be set in the function signature, but None has other meaning already.)

Header generator quality checks were pushed to PatchedHeaderGenerator to make sure they are also used in PatchedFingerprintGenerator

Issues

Pijukatel added 2 commits March 6, 2025 18:01
@Pijukatel
First has to solve hidden headers before proceeding wioth this. Other…
9b8865c 
…wise too many UTs fail on when using fingerprint generator
@Pijukatel
Fix all tests
35e9bf6
@Pijukatel Pijukatel changed the title feat: Use fingerprint generator in PlaywrightCrawler bu default feat: Use fingerprint generator in PlaywrightCrawler by default Mar 7, 2025
@github-actions github-actions bot added this to the 109th sprint - Tooling team milestone Mar 7, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Mar 7, 2025
@Pijukatel Pijukatel requested a review from vdusek March 7, 2025 10:25
@Pijukatel Pijukatel marked this pull request as ready for review March 7, 2025 10:26
vdusek
vdusek reviewed Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things.

@Pijukatel @vdusek
Apply suggestions from code review
6f58229 
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
B4nan
B4nan reviewed Mar 7, 2025
View reviewed changes
@Pijukatel Pijukatel requested a review from vdusek March 7, 2025 12:23
vdusek
vdusek approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pijukatel Pijukatel merged commit 09cec53 into master Mar 7, 2025
23 checks passed
@Pijukatel Pijukatel deleted the default-fp-generator branch March 7, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B4nan B4nan B4nan left review comments

@vdusek vdusek vdusek approved these changes

Assignees

@Pijukatel Pijukatel

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

109th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

feat: Make PlaywrightCrawler use fingerprint_generator by default

4 participants

@Pijukatel @B4nan @vdusek