Skip to content

Conversation

@Pijukatel
Copy link
Collaborator

@Pijukatel Pijukatel commented Mar 11, 2025

Description

This temporary fix is patching browserforge on import time.
This is needed until issue in the upstream repo is fixed to avoid downloading files when importing browserforge.

Same fix is added to two __init__ files of packages that through import chain trigger the undesired file download.

Issues

@github-actions github-actions bot added this to the 110th sprint - Tooling team milestone Mar 11, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Mar 11, 2025
@Pijukatel Pijukatel changed the title fix: Temporary workaround for browserforge import time code execution refactor: Temporary workaround for browserforge import time code execution Mar 11, 2025
@Pijukatel Pijukatel requested review from janbuchar and vdusek March 11, 2025 14:46
@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Mar 11, 2025
@Pijukatel Pijukatel marked this pull request as ready for review March 12, 2025 08:18
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this over the #1067.

@Pijukatel Pijukatel changed the title refactor: Temporary workaround for browserforge import time code execution fix: Temporary workaround for browserforge import time code execution Mar 12, 2025
@Pijukatel Pijukatel merged commit 17d914f into master Mar 12, 2025
24 checks passed
@Pijukatel Pijukatel deleted the temporary-browserforge-fix branch March 12, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants