fix: Use perf_counter_ns for request duration tracking
#1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
Pijukatel
force-pushed
the
use-perf-counter-for-request-duration
branch
from
d8d49f8 to
c29665d
Compare
vdusek
reviewed
Jun 19, 2025
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
janbuchar
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
datetime.nowbytime.perf_counter_nsin time difference calculations for request duration tracking to avoid possible issues connected to measured time resolution.This fixes the flakiness of
test_final_statisticsthat was happening on Windows and Python versions < 3.13.Issues
Testing
Newly added test was stress tested 500x times on old implementation to see the test sensitivity. On the source code before this PR the new test failed for Windows and Python versions 3.9,3.10,3.11,3.12 all 500 times. It did not fail even once for Linux or Windows + Python 3.13.