feat: Prevent overloading system memory when running locally #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janbuchar
commented
Jun 25, 2025
janbuchar
commented
- closes Autoscaling failsafe to prevent using up all memory when running locally #1232
janbuchar
added
the
t-tooling
github-actions
bot
added
the
tested
janbuchar
commented
Jun 25, 2025
janbuchar
commented
Jun 25, 2025
Pijukatel
reviewed
Jun 26, 2025
| current_size: ByteSize | ||
| """Memory usage of the current Python process and its children.""" | ||
|
|
||
| system_wide_used_size: ByteSize | None |
Collaborator
There was a problem hiding this comment.
Maybe these two new values can have default None, I saw it is anyway initialized with None both in code and test
Collaborator
Author
There was a problem hiding this comment.
But I already updated all the call sites... and I'd need to reorder the fields in the dataclass
Pijukatel
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.