Skip to content

refactor!: Change Dataset unwind parameter to accept list of strings #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Aug 15, 2025
Merged

refactor!: Change Dataset unwind parameter to accept list of strings #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawlee/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ class GetDataKwargs(TypedDict):
omit: NotRequired[list[str]]
"""Fields to exclude from each item."""

unwind: NotRequired[str]
unwind: NotRequired[list[str]]
"""Unwinds items by a specified array field, turning each element into a separate item."""

skip_empty: NotRequired[bool]
Expand Down
4 changes: 2 additions & 2 deletions src/crawlee/storage_clients/_base/_dataset_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ async def get_data(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
flatten: list[str] | None = None,
Expand All @@ -79,7 +79,7 @@ async def iterate_items(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
) -> AsyncIterator[dict[str, Any]]:
Expand Down
4 changes: 2 additions & 2 deletions src/crawlee/storage_clients/_file_system/_dataset_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ async def get_data(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
flatten: list[str] | None = None,
Expand Down Expand Up @@ -345,7 +345,7 @@ async def iterate_items(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
) -> AsyncIterator[dict[str, Any]]:
Expand Down
4 changes: 2 additions & 2 deletions src/crawlee/storage_clients/_memory/_dataset_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ async def get_data(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
flatten: list[str] | None = None,
Expand Down Expand Up @@ -188,7 +188,7 @@ async def iterate_items(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
) -> AsyncIterator[dict[str, Any]]:
Expand Down
6 changes: 3 additions & 3 deletions src/crawlee/storages/_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ async def get_data(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
flatten: list[str] | None = None,
Expand Down Expand Up @@ -197,7 +197,7 @@ async def iterate_items(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
) -> AsyncIterator[dict[str, Any]]:
Expand Down Expand Up @@ -245,7 +245,7 @@ async def list_items(
desc: bool = False,
fields: list[str] | None = None,
omit: list[str] | None = None,
unwind: str | None = None,
unwind: list[str] | None = None,
skip_empty: bool = False,
skip_hidden: bool = False,
) -> list[dict[str, Any]]:
Expand Down
Loading