Skip to content

Conversation

@vdusek
Copy link
Collaborator

@vdusek vdusek commented Aug 19, 2025

Description

  • Remove sortedcollections and sortedcontainers packages from dependencies.
  • Replace the sorted list in the Snapshotter with a custom class.

Issues

Testing

  • One new test for the SortedSnapshotList plus the current test set covers the changes.

Checklist

  • CI passed

@vdusek vdusek added this to the 121st sprint - Tooling team milestone Aug 19, 2025
@vdusek vdusek requested a review from Pijukatel August 19, 2025 08:08
@vdusek vdusek self-assigned this Aug 19, 2025
@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 19, 2025
@vdusek vdusek changed the title chore: Remove sortedcollections and sortedcontainers pkgs chore: Remove sortedcollections and sortedcontainers packages Aug 19, 2025
@vdusek vdusek force-pushed the rm-sorted-collections-containers branch from 3e975a3 to 72dddec Compare August 19, 2025 08:59
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Aug 19, 2025
@vdusek vdusek force-pushed the rm-sorted-collections-containers branch from 72dddec to 3dedc17 Compare August 19, 2025 09:01
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@vdusek vdusek force-pushed the rm-sorted-collections-containers branch from 3dedc17 to dd90b34 Compare August 19, 2025 09:10
@vdusek vdusek merged commit f332408 into master Aug 19, 2025
35 of 36 checks passed
@vdusek vdusek deleted the rm-sorted-collections-containers branch August 19, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize package footprint by removing unnecessary deps

4 participants