chore: fix flaky tests #1478
chore: fix flaky tests #1478
Conversation
Mantisus
force-pushed
the
flaky-tests
branch
3 times, most recently
from
7180ed4 to
ce992b9
Compare
| assert telemetry_data[-1]['attributes']['code.function.name'] == 'BasicCrawler.__run_task_function' | ||
| assert telemetry_data[-1]['resource']['attributes'] == dict(resource.attributes) | ||
|
|
||
| last_run_fuction_data = None |
There was a problem hiding this comment.
Is this needed? Maybe setting max_requests_per_crawl=1 and ConcurrencySettings(desired_concurrency=1, max_concurrency=1) should be enough
There was a problem hiding this comment.
I added this because I found some strange snapshots in the latest indexes a couple of times. Unfortunately, I didn't save the examples.
There was a problem hiding this comment.
It would be good to fully understand the issue; otherwise, I am worried it could be hiding some other problem.
Why are there some "strange snapshots in latest indexes" sometimes?
There was a problem hiding this comment.
Hmm. I probably encountered either a very rare case or a side effect caused by something else. Since I couldn't reproduce it. I'm removing this workaround for now, let's see if anything strange happens in CI.
2 participants
Issues
test_crawler_instrumentor_capabilityis flaky #1469test_gz_sitemap_with_non_gzippedis flaky #1460