fix: Fix non-ASCII character corruption in FileSystemStorageClient on systems without UTF-8 default encoding
#1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbuchar
reviewed
Nov 26, 2025
| await Dataset.open(name=name, storage_client=storage_client) | ||
|
|
||
|
|
||
| async def test_record_with_noascii_chars(dataset: Dataset) -> None: |
Collaborator
There was a problem hiding this comment.
The fix is in file system storage only. We can either move this check to file system storage client tests or test with all possible storage clients - your call.
Collaborator
Author
There was a problem hiding this comment.
I would keep the tests for all possible storage clients. 🙂
Collaborator
There was a problem hiding this comment.
Ah right, the dataset fixture uses the parametrized storage client fixture. Makes sense.
Pijukatel
approved these changes
Nov 26, 2025
janbuchar
approved these changes
Nov 26, 2025
| await Dataset.open(name=name, storage_client=storage_client) | ||
|
|
||
|
|
||
| async def test_record_with_noascii_chars(dataset: Dataset) -> None: |
Collaborator
There was a problem hiding this comment.
Ah right, the dataset fixture uses the parametrized storage client fixture. Makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FileSystemStorageClienton systems without UTF-8 default encodingIssues
Testing