fix: allow label in enqueueLinksByClickingElements options
#1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minupalaniappan
force-pushed
the
add-request-label-to-enqueue-links-by-click
branch
from
5017273 to
1f6bf00
Compare
B4nan
reviewed
Sep 7, 2022
packages/puppeteer-crawler/src/internals/enqueue-links/click-elements.ts
Outdated
Show resolved
Hide resolved
B4nan
changed the title
label in enqueueLinksByClickingElements options
B4nan
changed the title
label in enqueueLinksByClickingElements optionslabel in enqueueLinksByClickingElements options
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Crawlee team!
I'm currently developing on top of Crawlee, and have been leveraging
enqueueLinksByClickingElementsto navigate links that require the preservation of session data. There are thousands of links, so moving these page contexts into the request queue under a new label is preferred. I am currently seeing an issue with enqueueing new work with custom labels.A fix below, which ensures the validation of
labelinRequestOptionsenablesenqueueLinksByClickingElementsto queue up new links under a custom label.