Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(social): support new URL formats for Facebook, YouTube and X #2758

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(social): support new URL formats for Facebook, YouTube and X #2758

merged 1 commit into from
Dec 3, 2024

Conversation

lhotanok
Copy link
Contributor

Fixes #525

@janbuchar janbuchar self-requested a review December 3, 2024 12:32
janbuchar
janbuchar approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as longs as tests pass...

vladfrangu
vladfrangu approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, evergrowing regex patterns

@janbuchar janbuchar merged commit 4c95847 into apify:master Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@janbuchar janbuchar janbuchar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Few not matched social handles
3 participants
@lhotanok @janbuchar @vladfrangu