fix: process http over https proxy correctly #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, HTTP request (
http://example.com/resource
) over HTTPS proxy (https://proxy.com
) was sent as:https://proxy.com/example.com/resource
.After a discussion with @jirimoravcik , we figured that the "pathname" proxies are a marginal thing (
CONNECT
is more popular nowadays).This PR fixes that -
got-scraping
now does:https://proxy.com/
-> HTTP GEThttp://example.com/resource
.Yet, there is still this comment:
// Upstream proxies hang up connections on CONNECT + unsecure HTTP
maybe @szmarczak knows what that was supposed to mean? 😅 seems dangerously close to what we want to do now.
Fixes #126