-
Notifications
You must be signed in to change notification settings - Fork 1
11: Run Task Update #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@oleksandravalko please add at lest 2 reviews to every PR |
JanHranicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving 🙂 Found just a typo and have a question about webhooks xd
|
@drobnikj @JanHranicky updated, please review. |
JanHranicky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, ty for the changes 🙂
| @@ -1,120 +0,0 @@ | |||
| import apify from "../../apify.app.mjs"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would need to update the import here
https://github.com/apify/pipedream/blob/29f11c23b3285418e89a41b0340f5dbbb836774c/components/apify_oauth/actions/run-task-synchronously/run-task-synchronously.mjs
As pipedream created this second app with OAuth and import actions there.
Can you please check how breaking changes works in Pipedream? as we changed the action name it could breake some workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of conversation about deprecation:
- Currently there’s no concept of a component deprecation on Pipedream. There’s only the concept of
unpublisha component. - When Pipedream
unpublisha component, it means that the component is not visible for user to add to workflows. Existing workflows having that action will still work. - If we rename the component (change the key), we in fact remove
apify-run-task-synchronouslyand introduceapify-run-task. Removal of the component from code means, it will be unpublished by Pipedream manually. - We can theoretically keep for some time both actions, while on the older one instructing the user to switch to a new one, but "replace" approach described above is recommended one as it creates no work for the user.
So, imports are updated for OAuth version of the component, thanks for noticing it. In general, our changes on this component should do no harm.


Implements requirement of issue https://github.com/apify/integrations-team/issues/11
overrideInputinput field is introduced, its value is passed to the task execution;waitForFinishdetermines if the task run is just started or the workflow execution is supposed to paused before the run's finish and get dataset items after its finish;Please let me know how I could improve suggested change.
Waiting for the task run finishing (with

overrideInput):After the run is finished:

Only start the run without input override:
