Skip to content

Conversation

@oleksandravalko
Copy link

@oleksandravalko oleksandravalko commented Oct 6, 2025

Implements requirement of issue https://github.com/apify/integrations-team/issues/11

  • Component is renamed;
  • An overrideInput input field is introduced, its value is passed to the task execution;
  • A new waitForFinish determines if the task run is just started or the workflow execution is supposed to paused before the run's finish and get dataset items after its finish;
  • The huge part here is the logic utilising platform's ability to suspend and resume the execution, which frees us from a limiting timeout.

Please let me know how I could improve suggested change.

Waiting for the task run finishing (with overrideInput):
Screenshot 2025-10-06 at 17 50 29

After the run is finished:
Screenshot 2025-10-06 at 17 51 19

Only start the run without input override:
Screenshot 2025-10-06 at 17 51 42

@oleksandravalko oleksandravalko self-assigned this Oct 6, 2025
@drobnikj drobnikj requested a review from JanHranicky October 7, 2025 10:18
@drobnikj
Copy link
Member

drobnikj commented Oct 7, 2025

@oleksandravalko please add at lest 2 reviews to every PR

Copy link

@JanHranicky JanHranicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving 🙂 Found just a typo and have a question about webhooks xd

@oleksandravalko
Copy link
Author

@drobnikj @JanHranicky updated, please review.
image
image

Copy link

@JanHranicky JanHranicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, ty for the changes 🙂

@@ -1,120 +0,0 @@
import apify from "../../apify.app.mjs";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need to update the import here
https://github.com/apify/pipedream/blob/29f11c23b3285418e89a41b0340f5dbbb836774c/components/apify_oauth/actions/run-task-synchronously/run-task-synchronously.mjs

As pipedream created this second app with OAuth and import actions there.

Can you please check how breaking changes works in Pipedream? as we changed the action name it could breake some workflows

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of conversation about deprecation:

  • Currently there’s no concept of a component deprecation on Pipedream. There’s only the concept of unpublish a component.
  • When Pipedream unpublish a component, it means that the component is not visible for user to add to workflows. Existing workflows having that action will still work.
  • If we rename the component (change the key), we in fact remove apify-run-task-synchronously and introduce apify-run-task. Removal of the component from code means, it will be unpublished by Pipedream manually.
  • We can theoretically keep for some time both actions, while on the older one instructing the user to switch to a new one, but "replace" approach described above is recommended one as it creates no work for the user.

So, imports are updated for OAuth version of the component, thanks for noticing it. In general, our changes on this component should do no harm.

@drobnikj drobnikj self-requested a review October 21, 2025 09:38
@oleksandravalko oleksandravalko merged commit 306c854 into develop Oct 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants