fix(new-finished-actor-run-instant) 31: add actorSource input field, which determines the list of available actors in actorId list content #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which determines the list of available actors in actorId list content
drobnikj
approved these changes
Nov 25, 2025
Member
drobnikj
left a comment
drobnikj
left a comment
There was a problem hiding this comment.
Just one nore otherwise good 👍 pre-approve
| }) { | ||
| const listFn = actorSource === "store" | ||
| ? this.listActors | ||
| : this.listUserActors; |
Member
There was a problem hiding this comment.
Not sure if @MisaFialova report it or not.
The listUserActors should call actors().list() without param my: true. We want to return all Actors including from Store if user pick recently used
Author
There was a problem hiding this comment.
I see. Recent runs should include store actors as well. In this case, we missed it for the apify-run-actor component, where we should also list not only owned actors. I didn't question this part of the logic previously. I'll fix it for both components using the actorId input field.
… actor source is set on "recently-used"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
This point was marked as "solved", but I've looked into this comment anyway. I realised that the point is connected to
apify-new-finished-actor-run-instantsource/trigger, notapify-run-actorcomponent. So now, we can set the trigger for all actors finished run, own or store ones.OUTCOME
I attempted to test this trigger within the ‘apify-integration-development’ workspace but it appears that the lack of available credits prevents users from testing this type of integration. Screenshots are made from my account, where I still have some credits.