feat(apify): Prefill values from the input schema #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyascimbulka
force-pushed
the
feat/2-prefill-values-from-input-schema
branch
from
5870118 to
4b64f79
Compare
JanHranicky
approved these changes
Sep 4, 2025
JanHranicky
left a comment
JanHranicky
left a comment
There was a problem hiding this comment.
Looks good, leaving a small comment 🤠, but approving! 🫡
Comment on lines
212
to
222
| if (defaultValue) { | ||
| if (props[key].type !== "object") { | ||
| props[key].default = value.default; | ||
| props[key].default = defaultValue; | ||
|
|
||
| if (props[key].type === "string[]" && value.editor === "requestListSources") { | ||
| props[key].default = defaultValue.map((request) => request.url); | ||
| } | ||
| } | ||
|
|
||
| props[key].description += ` Default: \`${JSON.stringify(defaultValue)}\``; | ||
| } |
There was a problem hiding this comment.
Will this condition run for falsy values like 0 or false ?🤔
Collaborator
Author
There was a problem hiding this comment.
You're right. I think it would be better to check that the defaultValue isn't undefined.
drobnikj
requested changes
Sep 4, 2025
|
|
||
| if (value.default) { | ||
| props[key].description += ` Default: \`${JSON.stringify(value.default)}\``; | ||
| const defaultValue = value.default ?? value.prefill; |
Member
There was a problem hiding this comment.
I also wrote it into the issue
If the Actor has an input schema, let's use prefill values to prefill values in the form
I get that this is confusing, that in the Input Schema we called it prefill, but on the pipedream they call it default value, not sure if they have something like prefill.
The reson it that based on doc https://docs.apify.com/platform/actors/development/actor-definition/input-schema/specification/v1#prefill-vs-default-vs-required
the prefill is to guide the user on what to fill, what is exactly we wanted to do in the Run Actor action, get user idea , what to fill it by example.
Collaborator
Author
There was a problem hiding this comment.
Ok, that make sense.
drobnikj
approved these changes
Sep 8, 2025
matyascimbulka
added a commit
that referenced
this pull request
Sep 24, 2025
* feat(apify): Show list of built tags in actor run action * feat(apify): Allow selecting actor search source for run Actor action and change how Actor or task name is displayed * feat(apif): Remove wait for finish prop in run Actor action * fix(apify): Fix PR issues * fix(apif): Fix PR issues * fix(scrape-single-url): return the only dataset item after the run is finished (#3) * fix(scrape-single-url): return the only dataset item after the run is finished * fix(scrape-single-url): version up * fix(scrape-single-url): version up * fix(scrape-single-url): version up * fix(scrape-single-url): introduce a job status constant, expand a list of terminal statuses to stop the loop * fix(scrape-single-url): import constants from package, decrease delay in between calls * Migrate to use Apify client (#6) * feat(apify): Replace Axios with Apify client * fix(general): adding custom headers to client()=> preserve whole config to be passed to Axios later * feat(general): add linter script * fix(apify-get-dataset-items): a function for getting items and parsing of a result * fix(apify-run-actor): working sync and async, dynamic input schema injection, KVS output retrieval tested only string * fix(general): change maxResults for limit as an input field * fix(run-task-sync): move items retrieval to the component, add waitSecs determined by input or plan to prevent blunt timeout error, have the item retrieval logic be connected to run status, clean return value * fix(apify-scrape-single-url): incorporate timeouts, rework the whole API interaction logic * fix(apify-set-key-value-store-record): detection of content type, fixed API interaction * fix(apify-scrape-single-url): remove waiting timeout, return only dataset item, remove extra input fields connected to WCC run * fix(apify-run-actor): success message * fix(apify-run-task-synchronously): remove waiting for run to finish timeout * fix(app): remove paidPlan input filed config --------- Co-authored-by: Matyas Cimbulka <matyas.cimbulka@apify.com> * fix(apify-get-dataset-items) 6: change input parameters (#8) * chore(apify): Bump component versions * chore: Sync upstream repo (#9) * feat(apify): Prefill values from the input schema (#7) * Revert "chore: Sync upstream repo (#9)" This reverts commit cd804ba. * Revert "chore(apify): Bump component versions" This reverts commit 6040822 which for some reason bumped version of the wrong components. * fix(apify): Fix build tag * fix(apify): Address issues in run task synchronously action * feat(apify): Add default crawler type to scrape single url * fix(apify): Address issues from PR * chore(apify): Change component versions * fix(apify): Fix run Actor action * fix(apify): Fix run get dataset items action * fix(apify): Fix typos for PR --------- Co-authored-by: Oleksandra Valko <oleksandra.valko@apify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to this issue.
Improves the generation of the input props based on the input schema fetched from the Platform. When input field in the input schema doesn't have a default value the prefill value is used instead. Also all boolean fields are set to false unless changed by default or prefill setting.