Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for test failing for symfony 6.4 #342

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

divya-intelli
Copy link
Collaborator

@divya-intelli divya-intelli commented Jan 9, 2024

Closes #341
Serializer/Normalizer/AbstractNormalizer changed the exception type for Abstract class instantiate check.
As this check was introduced in symfony 6.3.11 , symfony/serialiser version is bumped.

@divya-intelli divya-intelli added this to the 3.0.4 milestone Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60b423c) 87.53% compared to head (b0e09d6) 87.60%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #342      +/-   ##
============================================
+ Coverage     87.53%   87.60%   +0.07%     
- Complexity     1719     1750      +31     
============================================
  Files           343      349       +6     
  Lines          4171     4704     +533     
============================================
+ Hits           3651     4121     +470     
- Misses          520      583      +63     
Flag Coverage Δ
unittests 87.60% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 116 files with indirect coverage changes

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divya-intelli divya-intelli merged commit 53181d7 into apigee:3.x Jan 9, 2024
6 checks passed
@shishir-intelli shishir-intelli modified the milestone: 3.0.4 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Composer test is failing in github action
2 participants