Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#65] Deprecate "createdBy" and "lastModifiedBy" properties #74

Merged
merged 6 commits into from
Oct 30, 2019
Merged

[#65] Deprecate "createdBy" and "lastModifiedBy" properties #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0377c43
[#65] Deprecate createdBy, lastModifiedBy properties as they are not …
arlina-espinoza Oct 21, 2019
ac8cc5b
[#65] Deprecate createdBy, lastModifiedBy properties - removing from …
arlina-espinoza Oct 21, 2019
2091a05
[#65] Deprecate createdBy, lastModifiedBy properties - add link to is…
arlina-espinoza Oct 25, 2019
33c4cd6
[#65] Code style fixes.
arlina-espinoza Oct 25, 2019
17c0651
[#65] Adding back createdBy and lastModifiedBy to tests and mock data.
arlina-espinoza Oct 25, 2019
695e19b
[#65] Deprecate createdBy, lastModifiedBy properties - more deprecati…
arlina-espinoza Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Entity/CommonEntityPropertiesAwareTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ trait CommonEntityPropertiesAwareTrait
/**
* Email address of the organization user who created the entity.
*
* @deprecated in 2.0.4, will be removed before 3.0.0. Unsupported in Hybrid.
* @see https://github.com/apigee/apigee-client-php/issues/65
*
* @var string|null
*/
protected $createdBy;
Expand All @@ -50,6 +53,9 @@ trait CommonEntityPropertiesAwareTrait
/**
* Email address of the organization user who modified the entity last time.
*
* @deprecated in 2.0.4, will be removed before 3.0.0. Unsupported in Hybrid.
* @see https://github.com/apigee/apigee-client-php/issues/65
*
* @var string|null
*/
protected $lastModifiedBy;
Expand Down Expand Up @@ -88,6 +94,9 @@ public function getCreatedBy(): ?string
* @param string $email
* User/developer mail.
*
* @deprecated in 2.0.4, will be removed before 3.0.0. Unsupported in Hybrid.
* @see https://github.com/apigee/apigee-client-php/issues/65
*
* @internal
*/
public function setCreatedBy(string $email): void
Expand Down Expand Up @@ -130,6 +139,9 @@ public function getLastModifiedBy(): ?string
* User/developer mail.
*
* @internal
*
* @deprecated in 2.0.4, will be removed before 3.0.0. Unsupported in Hybrid.
* @see https://github.com/apigee/apigee-client-php/issues/65
*/
public function setLastModifiedBy(string $email): void
{
Expand Down
6 changes: 6 additions & 0 deletions src/Entity/CommonEntityPropertiesInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ public function getCreatedAt(): ?\DateTimeImmutable;
/**
* Returns the email address of the user/developer who created the entity.
*
* @deprecated in 2.0.4, will be removed before 3.0.0. Unsupported in Hybrid.
* @see https://github.com/apigee/apigee-client-php/issues/65
*
* @return string|null Email address.
*/
public function getCreatedBy(): ?string;
Expand All @@ -52,6 +55,9 @@ public function getLastModifiedAt(): ?\DateTimeImmutable;
/**
* Returns the email address of the user/developer who modified the entity the last time.
*
* @deprecated in 2.0.4, will be removed before 3.0.0. Unsupported in Hybrid.
* @see https://github.com/apigee/apigee-client-php/issues/65
*
* @return string|null Email address.
*/
public function getLastModifiedBy(): ?string;
Expand Down