fix: modify install script to prioritize stable releases #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the script was picking whatever was the most recent released tag. This is not necessarily correct, as you can have tags for betas, and release candidates. We don't want customers installing the "latest" and end up using an unstable build. Now, we sort all the tags by the semantic version number, and then we pick the first stable one (not containing a dash). If we can't find any stable one, we pick the top one in the list.
ssvaidyanathan
approved these changes
May 1, 2024
|
pls make sure the script works on Windows as well |
|
@ssvaidyanathan , for Windows, should we target something like PowerShell, and have a separate script? Or are you referring to running the script in WSL ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the script was picking whatever was the most recent released tag. This is not necessarily correct, as you can have tags for betas, and release candidates. We don't want customers installing the "latest" and end up using an unstable build.
Now, we sort all the tags by the semantic version number, and then we pick the first stable one (not containing a dash). If we can't find any stable one, we pick the top one in the list.