Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace NewClient with NewRegistryClient #665

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

theganyo
Copy link
Member

Fixes #660

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #665 (9e92bcb) into main (62bdd9f) will not change coverage.
The diff coverage is 40.00%.

❗ Current head 9e92bcb differs from pull request most recent head 43891ea. Consider uploading reports for the commit 43891ea to get more accurate results

@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   53.91%   53.91%           
=======================================
  Files          77       77           
  Lines        7222     7222           
=======================================
  Hits         3894     3894           
  Misses       2914     2914           
  Partials      414      414           
Impacted Files Coverage Δ
cmd/registry/cmd/compute/complexity.go 0.00% <0.00%> (ø)
cmd/registry/cmd/compute/lint.go 0.00% <0.00%> (ø)
cmd/registry/cmd/compute/lintstats.go 0.00% <0.00%> (ø)
cmd/registry/cmd/compute/references.go 0.00% <0.00%> (ø)
cmd/registry/cmd/compute/score.go 0.00% <0.00%> (ø)
cmd/registry/cmd/compute/scorecard.go 0.00% <0.00%> (ø)
cmd/registry/cmd/compute/vocabulary.go 0.00% <0.00%> (ø)
cmd/registry/cmd/export/sheet.go 7.92% <0.00%> (ø)
cmd/registry/cmd/export/yaml.go 15.68% <0.00%> (ø)
cmd/registry/cmd/upload/spec.go 13.39% <0.00%> (ø)
... and 13 more

@theganyo theganyo marked this pull request as ready for review July 18, 2022 23:10
@theganyo theganyo requested a review from timburks July 18, 2022 23:41
gapic/doc.go Outdated Show resolved Hide resolved
@timburks
Copy link
Contributor

I filed this issue about the doc.go problem.

@theganyo theganyo merged commit 2c94ac7 into apigee:main Jul 19, 2022
@theganyo theganyo deleted the theganyo/issue660 branch July 19, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants