-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multiple-auth): add support for multiple auth #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for multiple auth i.e. authentication using And/Or combination. Now core library now uses the auth builder to validate and apply the provided auth combinations. It also uses the same design for single auth. closes #78
asadali214
previously approved these changes
Oct 6, 2023
…patibility for existing SDKs containing single auth
asadali214
previously approved these changes
Oct 16, 2023
asadali214
previously approved these changes
Oct 24, 2023
…done due to the default value of auth credentials in the SDK.
f6c9675
to
f8a9026
Compare
asadali214
approved these changes
Dec 5, 2023
sufyankhanrao
added a commit
that referenced
this pull request
Dec 8, 2023
This reverts commit 3baa14a.
sufyankhanrao
added a commit
that referenced
this pull request
Dec 8, 2023
sufyankhanrao
added a commit
that referenced
this pull request
Dec 8, 2023
sufyankhanrao
added a commit
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for multiple auth i.e. authentication using And/Or combination. Now core library now uses the auth builder to validate and apply the provided auth combinations. It also uses the same design for single auth.
Why
To support the multiple auth feature
closes #78
Type of change
Select multiple if applicable.
Dependency Change
If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries
Breaking change
If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries
Testing
List the steps that were taken to test the changes
Checklist