Skip to content

feat(http-header): add support for complex types #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

sufyankhanrao
Copy link
Collaborator

What

This PR adds support for processing complex object-typed header parameters in the request builder class. Also, adds the case-insensitivity behavior in the headers which was previously missing. Also, adds unit tests to validate handling of complex header parameters

Why

  • To support the custom types like scalar types, non-scalar types and collection of each types.

Closes #90

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commits adds support for processing complex object-typed header parameters in the request builder class. Also, adds the case-insensitivity behavior in the headers which was previously missing. Also, adds unit tests to validate handling of complex header parameters

Closes #90
@sufyankhanrao sufyankhanrao added the enhancement New feature or request label Feb 26, 2025
@sufyankhanrao sufyankhanrao self-assigned this Feb 26, 2025
Copy link
Contributor

@MaryamAdnan3 MaryamAdnan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions needs your answers

Copy link
Contributor

@MaryamAdnan3 MaryamAdnan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sufyankhanrao sufyankhanrao merged commit 5a37ba2 into main Feb 27, 2025
10 checks passed
@sufyankhanrao sufyankhanrao deleted the 90-add-complex-type-header-support branch February 27, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for custom type in Header Parameters
2 participants