Bugfix/Login attempt with Fiware throws Internal Server error #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, verified! |
anarva
reviewed
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Fixes Apinf bug 3209
Meteor is expecting service data to include a username field during the first login attempt.
When the field is not provided the value of result.error (AccountsServer.Ap._attemptLogin (packages/accounts-base/accounts_server.js) is not empty (Something like missing Username field)
That results on attempt.error being filled with result.error which causes a circular JSON error, which is why a 500 error is given (This seems to be a bug in the accounts_server.js)