User not notified after successful edit/update 'Branding' details

[saralavanip]

Steps

1. Visit https://nightly2.apinf.io
2. Login as admin
3. Go to Branding section
4. Update/edit Branding details (eg. site title or site slogan)
5. Click on 'Update' button

Findings

• First click on 'Update' button doesn't respond though the details are updated. It remains highlighted until next click.
• User not notified about successful update.

Browser

1. Mozilla Firefox 48.0
   (Mozilla Firefox for Ubuntu Canonical – 1.0 )
2. Google Chrome 52.0.2743.116

Operating System

1. Ubuntu 16.0 LTS

Screenshot

[saralavanip]

@bajiat , verified on https://nightly.apinf.io

Findings:

• Update/Edit 'Branding' details is successful but user not notified.

[philippeluickx]

@mauriciovieira If you are going to write unit tests for this, check out https://www.meteortesting.com/

[mauriciovieira]

After strugling with the recommended meteor way of doing unit tests. I decided to try the way Rocket.Chat does tests, using chimp in a end2end way.

Related: xolvio/chimp#433

[mauriciovieira]

I believe that we can test server methods using a setup similar to the recommended on meteor guides, such as https://github.com/gagarinjs/meteor-mocha

[mauriciovieira]

@philippeluickx this link points to a book that's being written at least since February and never gets released http://quality.xolv.io/. Nevertheless, the test runner that is being used by Rocket.Chat, chimp.js, was made by this xolvio. :-) Thanks for the tip.

[mauriciovieira]

closed by #2617