Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/testing infrastructure #2522

Merged
merged 41 commits into from
Jun 9, 2017
Merged

Conversation

mauriciovieira
Copy link
Contributor

@mauriciovieira mauriciovieira commented May 4, 2017

Following Rocket.Chat testing infrastructure.

What I have now is an end-to-end test using chimp.js that opens a browser and tests the login page. The test is currently flaky, not returning positive answer all times.

I would also like to make it to run in Travis, but it'd be better as a new task.

@mauriciovieira mauriciovieira added this to the Sprint 42 milestone May 4, 2017
@mauriciovieira
Copy link
Contributor Author

End-to-end tests for login page working:

screen shot 2017-05-05 at 18 52 54

But it requires the application to be running on other terminal.

Rocket.chat solves it in travis-ci with xfvb

brylie
brylie previously requested changes May 9, 2017

module.exports = {
// // - - - - CHIMP - - - -
// watch: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up unused code (comments)?

@mauriciovieira mauriciovieira force-pushed the feature/testing-infrastructure branch from 28856ec to 4b9183f Compare May 10, 2017 01:41
@brylie brylie assigned as33ms and unassigned brylie May 11, 2017
@mauriciovieira
Copy link
Contributor Author

After trying for a few weeks, I coudn't reliably test the Branding page following the official docs.

What I am trying to do here is to create a basic set of end to end tests inspired by Rocket.Chat tests.

Then, I will test the Branding page to close #1506.

@ashakunt @brylie Notice that we'll still have to run the end2end tests on travis, probably also following the Rocket.Chat example.

These e2e tests can add some regression tests on basic behavior, but we'll need a solution for testing the REST API as well as other server side methods (covered by #1714).

@mauriciovieira mauriciovieira force-pushed the feature/testing-infrastructure branch 5 times, most recently from 3f01ee4 to d4b0bbf Compare May 19, 2017 13:06
@mauriciovieira mauriciovieira force-pushed the feature/testing-infrastructure branch 5 times, most recently from d1fa040 to ee8d36e Compare May 24, 2017 19:21
@mauriciovieira mauriciovieira force-pushed the feature/testing-infrastructure branch 2 times, most recently from ae866ef to af67349 Compare May 30, 2017 18:37
@mauriciovieira
Copy link
Contributor Author

@brylie @ashakunt I added documentation on an initial suite of end to end tests. In order to run, it is necessary to have a meteor server running and also google chrome.

Please review.

This PR closes #2615

@mauriciovieira
Copy link
Contributor Author

@brylie I fixed your requests

@mauriciovieira mauriciovieira force-pushed the feature/testing-infrastructure branch 2 times, most recently from c26ba59 to dd535a1 Compare May 30, 2017 22:42
@mauriciovieira
Copy link
Contributor Author

Closes #2622 as well

@as33ms
Copy link
Contributor

as33ms commented Jun 1, 2017

Looking into it during today.

@mauriciovieira
Copy link
Contributor Author

@wuder4 please also take a look.

@as33ms
Copy link
Contributor

as33ms commented Jun 4, 2017

I reviewed this branch using my browser today (ideally, would have wanted to run stuff locally); and oh boy, wasn't it pain to review such a large chunk in Chrome.

In principle, I think its Ok to merge. However, a few things I would like to bring to notice: The testing team is looking forward to write the E2E tests in Robot + Selenium because they are easy to learn, write and run. So at this point, most of our test assets will start to be shown in that framework (at least all what will be contributed by @wuder4, unless, he is willing to learn chimp and already start with that?

IMHO, we should merge this to develop and try to develop our test assets using either CHIMP or ROBOT, what ever is preferred by the test writer. My personal fav is ROBOT because of its simplicity to read and write. Comments welcome.

@mauriciovieira
Copy link
Contributor Author

@brylie @wuder4 do you have comments?

@mauriciovieira mauriciovieira dismissed brylie’s stale review June 9, 2017 00:46

Changes already done.

@mauriciovieira mauriciovieira merged commit dad1af8 into develop Jun 9, 2017
@mauriciovieira mauriciovieira deleted the feature/testing-infrastructure branch June 11, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants