-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/testing infrastructure #2522
Conversation
End-to-end tests for login page working: But it requires the application to be running on other terminal. Rocket.chat solves it in travis-ci with xfvb |
tests/chimp-config.js
Outdated
|
||
module.exports = { | ||
// // - - - - CHIMP - - - - | ||
// watch: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up unused code (comments)?
28856ec
to
4b9183f
Compare
After trying for a few weeks, I coudn't reliably test the Branding page following the official docs. What I am trying to do here is to create a basic set of end to end tests inspired by Rocket.Chat tests. Then, I will test the Branding page to close #1506. @ashakunt @brylie Notice that we'll still have to run the end2end tests on travis, probably also following the Rocket.Chat example. These e2e tests can add some regression tests on basic behavior, but we'll need a solution for testing the REST API as well as other server side methods (covered by #1714). |
3f01ee4
to
d4b0bbf
Compare
d1fa040
to
ee8d36e
Compare
ae866ef
to
af67349
Compare
c26ba59
to
dd535a1
Compare
I just figured out that a file with explicit mess is not going to be useful :-)
- loginAsOrCreateUser still flaky
- admin / password will be the default first user, or at least an admin user on testing environment
dd535a1
to
b5d2cd8
Compare
Closes #2622 as well |
Looking into it during today. |
@wuder4 please also take a look. |
I reviewed this branch using my browser today (ideally, would have wanted to run stuff locally); and oh boy, wasn't it pain to review such a large chunk in Chrome. In principle, I think its Ok to merge. However, a few things I would like to bring to notice: The testing team is looking forward to write the E2E tests in Robot + Selenium because they are easy to learn, write and run. So at this point, most of our test assets will start to be shown in that framework (at least all what will be contributed by @wuder4, unless, he is willing to learn chimp and already start with that? IMHO, we should merge this to |
Following Rocket.Chat testing infrastructure.
What I have now is an end-to-end test using chimp.js that opens a browser and tests the login page. The test is currently flaky, not returning positive answer all times.
I would also like to make it to run in Travis, but it'd be better as a new task.