Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons in the UI must have an ID associated with them #2623

Closed
wuder4 opened this issue Jun 2, 2017 · 7 comments
Closed

Buttons in the UI must have an ID associated with them #2623

wuder4 opened this issue Jun 2, 2017 · 7 comments
Assignees

Comments

@wuder4
Copy link
Contributor

wuder4 commented Jun 2, 2017

Almost none of the buttons at apinf.io have valid way to locate them in automated testing. Common way to locate them is to add unique id to the buttons.

@as33ms as33ms changed the title Button id's Buttons in the UI must have an ID associated with them Jun 2, 2017
@as33ms
Copy link
Contributor

as33ms commented Jun 2, 2017

@wuder4 can you please point out the buttons and their locations which do not have the IDs?

@wuder4
Copy link
Contributor Author

wuder4 commented Jun 2, 2017

Its easier to say that any bar that you can add text to has ID:
searchbar id
Then there are 3 buttons "More APIs" above contact us, language selection button and "about" button at the end of the page.

@as33ms
Copy link
Contributor

as33ms commented Jun 2, 2017

Thanks, @wuder4. @brylie @bajiat Not only buttons, but all the UI elements in the page dom should have valid and unique IDs. This is a requirement for Automation Testing.

@mauriciovieira
Copy link
Contributor

@wuder4 I think this can be added on the go, while creating the automated tests. I added some ids/classes while doing #2522

@wuder4
Copy link
Contributor Author

wuder4 commented Jun 5, 2017

When in "add API" page the text fields have id but they are random and change every time you reload the page.

@bajiat
Copy link
Contributor

bajiat commented Jun 8, 2017

I have given the task to add id's to @wuder4 at least for the id's he is stuck with and has identified as missing. Some mentoring may be required from @55, @mauriciovieira or @ashakunt concerning the contribution process and how to add the id's and what is the correct format.

@bajiat bajiat added the ready label Jun 8, 2017
@mauriciovieira
Copy link
Contributor

ok. I think it is a good opportunity to document a convention on our guidelines if you find current code not standardized, @wuder4

@55 55 added in progress and removed ready labels Jun 14, 2017
@55 55 closed this as completed in #2655 Jun 15, 2017
@55 55 removed the in progress label Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants