Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by 'Life Cycle phase': Notify user when no APIs found with selected status #2396

Closed
saralavanip opened this issue Mar 31, 2017 · 6 comments

Comments

@saralavanip
Copy link
Contributor

saralavanip commented Mar 31, 2017

Steps

1.Visit https://staging.apinf.io v 0.42.0
2.Login
3.Go to API catalog
4.Filter by 'Life Cycle' status (eg. deprecated)

Findings

  • When no 'APIs' found by selected status , the sorting result is shown as: 'Filtered by "Deprecated" "Clear All"
  • Sort result could notify user eg. "No APIs found with the selected life cycle status"

Screenshot

sort_results_lifecycle_status

@bajiat
Copy link
Contributor

bajiat commented Aug 25, 2017

@Nazarah Is the suggested notification text ok for you? "No APIs found with the selected life cycle status"

@Nazarah
Copy link
Contributor

Nazarah commented Aug 28, 2017

@bajiat I beleive the text should be the same for all cases, whenever a search query doesn't return a result. A simple text "No API found." is sufficient for this.

@bajiat bajiat added in progress and removed icebox labels Aug 29, 2017
@marla-singer marla-singer added this to the Sprint 51 milestone Aug 31, 2017
@wuder4
Copy link
Contributor

wuder4 commented Sep 18, 2017

Now it shows this error every time you have 0 results in API catalog. eg. if you look at your bookmarks and you have no APIs in bookmarks. It tells you:
No APIs found with the selected life cycle status

If the error says "No API found." it would not be a problem

@saralavanip
Copy link
Contributor Author

@bajiat , observed on staging v 0.50.0 : Related screenshots below.

staging_0 50 0_myapis_incorrect_msg

staging_v0 50 0_no_apis_incorrect_msg

staging_v0 50 0_mybookmarks

@bajiat bajiat removed this from the Sprint 51 milestone Oct 2, 2017
@Nazarah
Copy link
Contributor

Nazarah commented Nov 13, 2017

@vellames what is the status for this issue? It has been in Progress for 2 months.

@preriasusi
Copy link
Contributor

Not repro in production 0.50.0 at apinf.io.

@ghost ghost removed the in progress label Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants