Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user when no APIs found with selected status #2854

Merged
merged 3 commits into from
Aug 30, 2017

Conversation

vellames2
Copy link
Contributor

Closes #2396

Added a notify when no APIs found with selected status.

@vellames2
Copy link
Contributor Author

@saralavanip, @bajiat ready for review

@vellames2
Copy link
Contributor Author

One more thing, i used the google translator to generate the Suomi string, i am not sure if the text are correct

@marla-singer
Copy link
Contributor

marla-singer commented Aug 28, 2017

@vellames Don't provide Finnish text. It will be added by @bajiat in a translation round. A developer role is to create an i18n tag for the English language.

@vellames2
Copy link
Contributor Author

@marla-singer Ok, thank you for the information.

@vellames2
Copy link
Contributor Author

@marla-singer translation removed

@@ -71,7 +71,7 @@
"apiCardPin_unfeaturedSuccessfully": "API card removed from featured list successfully",
"apiCatalog_apisCount": "(__count__ api)",
"apiCatalog_apisCount_plural": "(__count__ apis)",
"apiCatalog_noApis_Found": "No APIs found with the selected life cycle status",
"apiCatalog_noApis_Found": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vellames Sorry for disinformation. I meant a developer create i18n tag and write the English text for this tag. So back the English text again 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marla-singer no problem :)
Inserted again

inserts translation for english again
@marla-singer marla-singer merged commit bac054e into develop Aug 30, 2017
@marla-singer marla-singer deleted the feature/notify-no-apis-found branch August 30, 2017 13:35
@marla-singer marla-singer self-assigned this Aug 30, 2017
@marla-singer marla-singer added this to the Sprint 51 milestone Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants