Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental selection of non json/yaml/yml file doesn't allow valid json/yaml/yml file to load in Documentation tab #3245

Closed
Nazarah opened this issue Dec 15, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@Nazarah
Copy link
Contributor

Nazarah commented Dec 15, 2017

Steps to Reproduce:

  1. go to page: https://vamos.apinf.io and login as an API owner
  2. Click an API and go to documentation tab
  3. Click Manage button, select File type from dropmenu and click choose file.
  4. 1st try to select a non json/yaml/yml file
  5. Observe the s-alert about file format.
  6. now upload a json/yaml file and click save

Outcome:
No preview appears behind the API documentation dialog
Uploaded json/yaml/yml API documentation doesn't get loaded in the documentation tab. Spinner keeps on loading.
spinner appears above if API document dialog is opened via Manage button.
http://recordit.co/Nnpbq1v31F

Expected Behavior:

It should be possible to load a valid json/yaml/yml file after the previous attempt to upload a non-supported file format.
Documentation should appear normally in the documentation tab

Environment:
Windows 10, Chrome browser (latest), APInf vamos deployment (https://vamos.apinf.io)

@Nazarah Nazarah added the bug label Dec 15, 2017
@Nazarah
Copy link
Contributor Author

Nazarah commented Dec 15, 2017

Tested and confirmed the behavior in https://nightly.apinf.io

user needs to delete the file and then reupload it for the documentation to be viewable.

@marla-singer marla-singer self-assigned this Dec 15, 2017
@marla-singer marla-singer added this to the Sprint 61 milestone Dec 15, 2017
marla-singer added a commit that referenced this issue Dec 15, 2017
@ghost ghost added the in progress label Dec 15, 2017
@ghost ghost removed the in progress label Dec 15, 2017
anarva pushed a commit that referenced this issue Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants