Feature/add unit test #2449
Closed
Feature/add unit test #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciovieira
force-pushed
the
feature/add_unit_test
branch
from
4f7e03c to
532296d
Compare
|
related kadirahq/flow-router#608 |
|
@mauriciovieira I studied the issue comments and as I think can fix it for us. I created the branch that is based on yours. Please test it (PR ##2455) |
|
@marla-singer thank you. I am checking it out. |
|
possible workaround kadirahq/flow-router#615 (but not a solution) |
mauriciovieira
force-pushed
the
feature/add_unit_test
branch
2 times, most recently
from
965c899 to
4329102
Compare
mauriciovieira
force-pushed
the
feature/add_unit_test
branch
from
63bdcf5 to
ec4b881
Compare
- Install meteor - Cache meteor installation - Run tests - Run eslint as a pretest step - Inspired by https://github.com/RocketChat/Rocket.Chat/blob/16743fb2c80f575fd2021d42ac5e31df76db128f/.travis.yml
The method checkes if current user has an admin role
Check if user is admin usgin the server method Add route '/users' as "requireAdminRole"
This reverts commit e0ae737.
This reverts commit 53e85d5.
- [ERROR] There is no route for the path: /
This reverts commit a982d14.
- test-chrome now uses dispatch:mocha-browser - npm test now only runs test-nightmare
- https://travis-ci.org/apinf/platform/builds/223464835 error seems to be cause by current installed packages - TODO: add caching back after build is OK
mauriciovieira
force-pushed
the
feature/add_unit_test
branch
from
ec4b881 to
f71d722
Compare
|
Should we close this PR, since you are working on end-to-end testing in another PR? |
|
@brylie yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1714