Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace path "/users/{id}" into related folder #2679

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

marla-singer
Copy link
Contributor

@marla-singer marla-singer commented Jun 21, 2017

  • Remove path "/users/{id}" from ApiV1.swagger.meta.paths in file "core/server/api.js", save a placeholder
  • Remove swagger part from origin REST API file. Because of restivus-swagger doesn't create properly Swagger documentation for Users collection, this part was removed. Now it allows us two different part: one of this provides the only feature for creating Swagger file (ApiV1.swagger.meta.paths) and another one provides only logic for REST API

Related to #2648 (issue)
Repated to #2651 (PR)

@matleppa Please, review this PR.
Look at Swagger file - it is still correct. Call couple request to /users/{id} - it still works properly.

Remove path "/users/{id}" from ApiV1.swagger.meta.paths in file "core/server/api.js", save a placeholder
Remove swagger part from origin REST API file. Because of restivus-swagger doesn't create properly Swagger documentation for Users collection, thispart wasremoved. Now it allows us two different part: one ofthis provides only feature for creating Swagger file (ApiV1.swagger.meta.paths) and another one provides only logic for REST API
@marla-singer marla-singer added this to the Sprint 45 milestone Jun 21, 2017
@marla-singer marla-singer requested a review from matleppa June 21, 2017 15:17
@matleppa matleppa merged commit 0e4108f into user-api-req-user-with-id Jun 26, 2017
@matleppa matleppa deleted the feature/not-duplicate-code branch June 26, 2017 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants