Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sAlert to add/change/remove backlog #1794 #3199

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Add sAlert to add/change/remove backlog #1794 #3199

merged 1 commit into from
Dec 14, 2017

Conversation

marla-singer
Copy link
Contributor

Closes #1794

Changes

  • Add sAlert and i18n tags

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@marla-singer marla-singer added this to the Sprint 60 milestone Dec 7, 2017
@marla-singer marla-singer requested a review from matleppa December 7, 2017 14:03
@ghost ghost assigned marla-singer Dec 7, 2017
matleppa
matleppa requested changes Dec 8, 2017
View reviewed changes
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase the alert texts, because here we handle only one backlog item at a time and not whole backlog.

apinf_packages/core/lib/i18n/en.i18n.json Outdated
@@ -296,6 +298,7 @@
"deleteBacklogItem_confirmation_text": "Are you sure you want to delete this backlog item?",
"deleteBacklogItem_cancelButton_text": "Cancel",
"deleteBacklogItem_deleteButton_text": "Delete backlog item",
"deleteBacklogItem_message_backlogRemoved": "The backlog was removed",
Copy link
Member

@matleppa matleppa Dec 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The backlog was removed"
-->
"One backlog item was removed"
"The backlog item was removed"

apinf_packages/core/lib/i18n/en.i18n.json Outdated
@@ -78,6 +78,8 @@
"apiBacklogItems_priorityText_High": "High",
"apiBacklogItems_priorityText_Middle": "Middle",
"apiBacklogItems_priorityText_None": "None",
"apiBacklogItemForm_message_backlogAdded": "The backlog was added",
Copy link
Member

@matleppa matleppa Dec 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The backlog was added"
-->
"One backlog item was added"
"The backlog item was added"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "one"? We don't use "one" anywhere in the same context.
"The" means "This" in the current context.
Sorry, can't agree with it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the idea, that in API card there is a backlog, which contains items.
The items can be added, modified and deleted, not the backlog itself.

Button
image

Modal
image

If you do not like word "one" to be included in alert, we can say e.g. "A backlog item was added"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But "The backlog item was changed/removed" because it was deleted the specified item, doesn't it?

Copy link
Member

@matleppa matleppa Dec 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I changed my comments accordingly.

apinf_packages/core/lib/i18n/en.i18n.json Outdated
@@ -78,6 +78,8 @@
"apiBacklogItems_priorityText_High": "High",
"apiBacklogItems_priorityText_Middle": "Middle",
"apiBacklogItems_priorityText_None": "None",
"apiBacklogItemForm_message_backlogAdded": "The backlog was added",
"apiBacklogItemForm_message_backlogChanged": "The backlog was changed",
Copy link
Member

@matleppa matleppa Dec 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The backlog was changed"
-->
"One backlog item was changed"
"The backlog item was changed"

@marla-singer marla-singer modified the milestones: Sprint 60, Sprint 61 Dec 12, 2017
@marla-singer marla-singer force-pushed the feature/aslert-messages-backlog branch from 6e26e07 to f84d8a6 Compare December 12, 2017 16:21
@marla-singer marla-singer merged commit ce852bf into develop Dec 14, 2017
@ghost ghost removed the Ready for review label Dec 14, 2017
@marla-singer marla-singer deleted the feature/aslert-messages-backlog branch December 14, 2017 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matleppa matleppa matleppa approved these changes

Assignees

@marla-singer marla-singer

@matleppa matleppa

Labels
None yet
Projects
None yet
Milestone
Sprint 61
Development

Successfully merging this pull request may close these issues.
2 participants
@marla-singer @matleppa