Feature/revoke api key should have confirm dialog #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
marla-singer
suggested changes
Jan 22, 2018
| @@ -32,4 +32,46 @@ | |||
| </button> | |||
| {{/ if }} | |||
| {{/ if }} | |||
| <!-- regenerate api key confirmation modal section --> | |||
| <div class="modal fade" id="regenerate-api-key-confirmation-modal"> | |||
There was a problem hiding this comment.
Create a new template for Modal form and place all logic/handler of this template to separate file. The value of API key you can provide to Modal. Look at another implementation of Modal form (for example, for Backlog)
| "regenerateApiKeyConfirmation_confirmRegenerateMessage": "Are you sure you want to revoke API key?", | ||
| "regenerateApiKeyConfirmation_confirmRegenerateNote": "NOTE:", | ||
| "regenerateApiKeyConfirmation_confirmRegenerateInformation": | ||
| "Revoking API key will stop calls with old API key to following APIS: .", |
There was a problem hiding this comment.
- Make it as one line
- remove the last dot in the sentence
- APIS -> APIs
| // Get all APIs ID that are connected to specify Proxy | ||
| const apiIds = ProxyBackends.find({ proxyId }).map(backend => { return backend.apiId; }); | ||
| // Find all APIs that are connected to Proxy | ||
| const apisList = Apis.find({ _id: { $in: apiIds } }).fetch(); |
There was a problem hiding this comment.
Add a filter by user. I mean that find all connected APIs that the current user manages.
Add additional rule
|
@deligence-dharmendra The last |
fixed travis ci issue fixed travis issue fixed new changes fixed travis ci issue
deligence-dharmendra
force-pushed
the
feature/revoke-api-key-should-have-confirm-dialog
branch
from
a673e63 to
07deb4e
Compare
|
Will look at it tomorrow |
marla-singer
approved these changes
Jan 25, 2018
marla-singer
deleted the
feature/revoke-api-key-should-have-confirm-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3322
Changes
Developer checklist
This checklist is to be completed by the PR developer:
Reviewer checklist
Reviewed by: @marla-singer @matleppa
This list is to be completed by the pull request reviewer: