Implement Sort option on the Dashboard page #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
marla-singer
force-pushed
the
feature/sort-option
branch
from
ee1368b to
f190e84
Compare
marla-singer
changed the title
marla-singer
force-pushed
the
feature/sort-option
branch
from
f190e84 to
9c2aae9
Compare
anarva
reviewed
Jan 29, 2018
| return a.apiName.localeCompare(b.apiName, language); | ||
| }); | ||
|
|
||
| break; |
There was a problem hiding this comment.
Break statement is not needed in the last block of switch.
matleppa
requested changes
Jan 29, 2018
| } | ||
|
|
||
| return count; | ||
| // Return boolean value of available overviewChart response |
There was a problem hiding this comment.
Comment seems to be a copy from above, correct it.
| }, | ||
| groupingApiIds () { | ||
| gorupingBackendIds (proxyId) { |
There was a problem hiding this comment.
gorupingBackendIds --> groupingBackendIds
| const proxyId = FlowRouter.getQueryParam('proxy_id'); | ||
| if (proxyId) { | ||
| // Get Proxy backend IDs for grouping | ||
| Meteor.call('gorupingBackendIds', proxyId, (err, res) => { |
There was a problem hiding this comment.
gorupingBackendIds --> groupingBackendIds
- groupingApiIds remake to groupingBackendIds. Now there returns IDs of Proxy Backends - Changed summaryStatisticNumber method: add parameter proxyBackendIds - Removed summaryStatisticTrend method - Added totalNumberRequestsAndTrend method: return total number for current period and comparison data with previous period - Code refactoring, clean up
marla-singer
force-pushed
the
feature/sort-option
branch
from
9c2aae9 to
f9103fd
Compare
|
@matleppa Done |
matleppa
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2758
Implement the sort feature, sort by name (a-z), calls (desc), user count (desc), response time(desc)
Changes
Developer checklist
This checklist is to be completed by the PR developer:
Reviewer checklist
Reviewed by: @username1
This list is to be completed by the pull request reviewer: