Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finnish translations update #3467

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Finnish translations update #3467

merged 2 commits into from
Apr 26, 2018

Conversation

preriasusi
Copy link
Contributor

Closes #

Changes

Describe your changes here as a bulleted list:

  • change one
  • change two

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned preriasusi Apr 26, 2018
@ghost ghost added the in progress label Apr 26, 2018
@preriasusi preriasusi requested a review from matleppa April 26, 2018 07:05
matleppa
matleppa requested changes Apr 26, 2018
View reviewed changes
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes needed.

apinf_packages/core/lib/i18n/fi.i18n.json Outdated
"apiAnalyticPageBody_text_usersCount_plural": "__count__ k\u00e4ytt\u00e4j\u00e4\u00e4",
"apiAnalyticPageBody_helpText_averageUniqueUsers": "Valitun ajanjakson eri k\u00e4ytt\u00e4jien m\u00e4\u00e4r\u00e4n keskiarvo",
"apiAnalyticPageBody_chartTitle_apiRequests": "Rajapinnalle l\u00e4hetetyt pyynn\u00f6t",
"apiAnalyticPageBody_chartTitle_medianResponseTime": "Rajapinnalle l\u00e4hetetyt pyynn\u00f6t",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"apiAnalyticPageBody_chartTitle_medianResponseTime": "Rajapinnalle l\u00e4hetetyt pyynn\u00f6t",
Seems to be copy-paste from Request chart
--> "Rajapinnan vasteaikojen mediaani"

apinf_packages/core/lib/i18n/fi.i18n.json Outdated
"errorsStatisticTable_columnTitle_date": "P\u00e4iv\u00e4m\u00e4\u00e4r\u00e4",
"errorsStatisticTable_columnTitle_status": "Tilakoodi:",
"errorsStatisticTable_columnTitle_calls": "Kutsut",
"errorsStatisticTable_columnTitle_path": "Pyynn\u00f6n polku",
"errorsStatisticTable_text_showOfErrors": "N\u00e4yt\u00e4 __count__ __all__ virheest\u00e4",
"errorsStatisticTable_text_showOfErrors": "N\u00e4yt\u00e4 __count__ yhteens\u00e4 __all__ virheist\u00e4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

virheistä --> virheestä

apinf_packages/core/lib/i18n/fi.i18n.json
@@ -485,14 +507,16 @@
"organizationLogo_resumable_acceptedExtensions": "Tuetut tiedostomuodot: .jpg, .jpeg, .png, .gif.",
"organizationManagersList_title": "Organisaation yll\u00e4pit\u00e4j\u00e4t",
"organizationManagerForm_successMessage": "Uusi yll\u00e4pit\u00e4j\u00e4 lis\u00e4tty.",
"organizationManagerForm_emailNotRegistered_errorText": "T\u00e4t\u00e4 s\u00e4hk\u00f6postiosoitetta ei ole viel\u00e4 rekister\u00f6ity j\u00e4rjestelm\u00e4\u00e4n.",
"organizationManagerForm_userNotRegistered_errorText": "K\u00e4ytt\u00e4j\u00e4n tili\u00e4 ei l\u00f6ydy.",
"organizationManagerForm_managerAlreadyExist_errorText": "K\u00e4ytt\u00e4j\u00e4 on jo t\u00e4m\u00e4n organisaation yll\u00e4pit\u00e4j\u00e4.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ylläpitäjä --> hallinnoija

matleppa
matleppa approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OK

@matleppa matleppa merged commit 56f3df4 into develop Apr 26, 2018
@ghost ghost removed the in progress label Apr 26, 2018
@matleppa matleppa deleted the Localisation_round_fi branch April 26, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matleppa matleppa matleppa approved these changes

Assignees

@preriasusi preriasusi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preriasusi @matleppa