Skip to content

Fix case sensitive for Proxy Backend frontend prefix #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

marla-singer
Copy link
Contributor

Closes #3477
Closes #3475

Issues contain steps for reproduce

Changes

  • Add .toLowerCase() when a request to ES is built
  • Additional condition for searching Proxy Backend with the same frontend prefix excluding case

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@matleppa
Copy link
Member

@marla-singer Finding this was a good catch!

And then to findings.

I tried it with two APIs, one having only lowercase characters in frontend_prefix and other one having also uppercase character included.

API with an uppercase letter in frontend_prefix
I think that the lowercase conversion might be missing when forming the conditions for fetching data for

  • API Request Timeline
  • API Response Time
  • Most Frequent Users

The charts are empty and also corresponding drop-down menus.

image

For comparison: API with all lowercase letters in frontend_prefix

image

Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality as expected

@matleppa matleppa merged commit 5051b39 into develop Jun 14, 2018
@ghost ghost removed the in progress label Jun 14, 2018
@matleppa matleppa deleted the fix-case-sensitive branch June 14, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants