Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use REST API to connect an API to a proxy #3547

Merged
merged 9 commits into from
Aug 21, 2018
Merged

Use REST API to connect an API to a proxy #3547

merged 9 commits into from
Aug 21, 2018

Conversation

matleppa
Copy link
Member

@matleppa matleppa commented Aug 17, 2018 •
edited
Loading

Closes #3143

Changes

  • in case API is connected to a proxy, manager sees also backend URL, backend prefix, proxy name and proxy type in API data
  • ability to list apiUmbrella proxy connections of an API
  • ability to connect an API to an apiUmbrella Proxy
  • ability to disconnect an API from an apiUmbrella Proxy

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned matleppa Aug 17, 2018
@ghost ghost added the in progress label Aug 17, 2018
@matleppa matleppa requested a review from preriasusi August 17, 2018 09:09
@matleppa
Changes port from 448 to 443 in examples
0a5f3c3
@matleppa
/PUT apiUmbrella update related changes
f006b54 
- removed unnecessary deletion of apiUmbrella key
- added missing apiUmbrella update call
- added missing publish API call
@matleppa
Ability to change proxy connection
162d30b
@matleppa
Lint fixes
ec7f9fe
@matleppa
PUT, removed change of proxy id
da14289
@preriasusi preriasusi merged commit fba5ffe into develop Aug 21, 2018
@preriasusi preriasusi deleted the feature/use-rest-api-to-connect-api-to-proxy branch August 21, 2018 08:54
@ghost ghost removed the Ready for review label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preriasusi preriasusi preriasusi approved these changes

Assignees

@matleppa matleppa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matleppa @preriasusi