Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow URLs without protocol #3551

Merged
merged 4 commits into from
Sep 4, 2018
Merged

Allow URLs without protocol #3551

merged 4 commits into from
Sep 4, 2018

Conversation

vinaytech
Copy link
Collaborator

@vinaytech vinaytech commented Aug 24, 2018 •
edited
Loading

Closes #2290

Changes

Describe your changes here as a bulleted list:

  • change one
  • change two

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @matleppa

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned vinaytech Aug 24, 2018
@ghost ghost added the in progress label Aug 24, 2018
matleppa
matleppa requested changes Aug 28, 2018
View reviewed changes
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrections needed: also protocol http:// needs to be accepted.

apinf_packages/apis/client/profile/details/autoform.js Outdated
AutoForm.hooks({
apiDetailsForm: {
formToModifier: (doc) => {
const host = 'https://';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: this checks only https://, not http://, which is still acceptable protocol.

apinf_packages/apis/client/add/autoform.js Outdated
@@ -14,6 +14,15 @@ import { sAlert } from 'meteor/juliancwirko:s-alert';

AutoForm.hooks({
addApiForm: {
formToDoc: (doc) => {
const host = 'https://';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: this checks only https://, not http://, which is still acceptable protocol.

matleppa
matleppa approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@matleppa matleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality as expected

@matleppa matleppa merged commit 07a5987 into develop Sep 4, 2018
@ghost ghost removed the Ready for review label Sep 4, 2018
@matleppa matleppa deleted the bugfix/allow-urls-without-protocol-2290 branch September 4, 2018 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matleppa matleppa matleppa approved these changes

Assignees

@vinaytech vinaytech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinaytech @matleppa