Allow setting scissor rectangle on RenderView #28
Conversation
jayrulez
force-pushed
the
scissor
branch
6 times, most recently
from
275a146 to
034e79f
Compare
Set initial scissor in begin pass Added render block for setting scissor
code/Render/Types.h
Outdated
| { | ||
| } | ||
|
|
||
| bool operator==(const Rectangle& other) const |
There was a problem hiding this comment.
Why these operators? Doesn't seem to be necessary and if necessary should be using "= default".
There was a problem hiding this comment.
I'm using it in the RmlUi implementation. I'm caching the last set scissor. When RmlUi wants me to set set the scissor, I check the last set scissor against the new one to avoid unnecessary calls to the vulkan backend.
I updated to use the default implementation, but if you would prefer to not have it here, then I can just do a more verbose check in the RmlUi integration.
There was a problem hiding this comment.
I’ll remove the equality operator, rebase, and squash the fix up commits. I’m not sure if I remember right, but we may lost the review comments after a force push
Add scissor to dynamic states in vulkan backend.
Set initial scissor in begin pass
Set scissor in WorldRendererShared::setupLightPass to match viewport