Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes | referral, DNS filtering, and a bit more. #127

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Fixes | referral, DNS filtering, and a bit more. #127

merged 4 commits into from
Mar 7, 2024

Conversation

cmm-apli
Copy link

@cmm-apli cmm-apli commented Mar 7, 2024

Description

  • Fix to avoid duplicated message on referral
  • Fix to avoid duplicated conversation on referral
  • Enh to allow multiple DNS at URL whitelisting separated by pipe
  • Fix for tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

AranGarcia
AranGarcia approved these changes Mar 7, 2024
View reviewed changes
Copy link

@AranGarcia AranGarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but I just got a question.

app/controllers/widgets_controller.rb Show resolved Hide resolved
@cmm-apli cmm-apli merged commit 20fac61 into develop Mar 7, 2024
6 checks passed
@cmm-apli cmm-apli self-assigned this Mar 7, 2024
@cmm-apli cmm-apli mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanDavd AlanDavd AlanDavd approved these changes

@AranGarcia AranGarcia AranGarcia approved these changes

@Behtsa Behtsa Awaiting requested review from Behtsa

@Arjona99 Arjona99 Awaiting requested review from Arjona99

Assignees

@cmm-apli cmm-apli

Labels
1 min review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmm-apli @AranGarcia @AlanDavd