Add min-group-size and max-group-size directive #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define min-group-size and max-group-size options in the exercise directives `submit` and `questionnaire`. Fixes apluslms#70
markkuriekkinen
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Excellent! I will slightly adjust the commit message and merge this. Note that min-group-size is not a "directive" but an option to the directives submit and questionnaire.
https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#directives
markkuriekkinen
force-pushed
the
group-size-directive
branch
from
69434d8 to
ff817f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define min-group-size and max-group-size directives in ConfigurableExercise, and add data to Questionnaire and SubmitForm
Fixes #70
Description
What?
Add group size directives
Why?
Before this could only be defined in the config globally
How?
Add group size options to
option_specinConfigurableExercise, define data inSubmitFormandQuestionnaireFixes #70
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!