Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identical/duplicate submission warning should not be shown in git repo submissions #1076

Closed
markkuriekkinen opened this issue Sep 9, 2022 · 1 comment · Fixed by #1283
Closed

Identical/duplicate submission warning should not be shown in git repo submissions #1076

markkuriekkinen opened this issue Sep 9, 2022 · 1 comment · Fixed by #1283
Assignees
@ihalaij1
Labels
area: UX student User experience and usability for students effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requester: CS The issue is raised internally by a CS teacher requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug
Milestone
v1.20.X patches i...

Comments

@markkuriekkinen
Copy link
Contributor

#1048 added a warning when the student makes an identical submission to a previous one. However, in assignments that take submissions as git repos, the submission is always expected to be the same git URL. The identical submission warning should not be shown in git repo submissions.

Git repo assignments use the MOOC-Grader view_type access.types.stdasync.acceptGitAddress.
C++ 2022 course is one example of a course that uses git repo submissions.

image
@markkuriekkinen markkuriekkinen added type: bug This is a bug area: UX student User experience and usability for students effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requester: CS The issue is raised internally by a CS teacher requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) labels Sep 9, 2022
@jykesaviaGNH
Copy link

I believe that Tampere teachers have similar submissions, which are not neccessary of type acceptGitAddress. Perhaps there should be an option to disable the duplicate check?

ihalaij1 added a commit to ihalaij1/a-plus-rst-tools that referenced this issue Oct 10, 2023
@ihalaij1
Add option to disable duplicate submission check
5b8b840 
Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Part of apluslms/a-plus#1076
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Oct 10, 2023
@ihalaij1
Support disabling duplicate submission check
6a2f5b1 
Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Fixes apluslms#1076
@ihalaij1 ihalaij1 mentioned this issue Oct 10, 2023
Merged
18 tasks
@ihalaij1 ihalaij1 self-assigned this Oct 10, 2023
@ihalaij1 ihalaij1 moved this from Todo to Under review in A+ sprints Oct 10, 2023
@ihalaij1 ihalaij1 mentioned this issue Oct 10, 2023
Merged
18 tasks
markkuriekkinen pushed a commit to apluslms/a-plus-rst-tools that referenced this issue Oct 17, 2023
@ihalaij1 @markkuriekkinen
Add option to disable duplicate submission check
f0885a1 
Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Part of apluslms/a-plus#1076
markkuriekkinen pushed a commit that referenced this issue Oct 17, 2023
@ihalaij1 @markkuriekkinen
Support disabling duplicate submission check
bdc477a 
Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Fixes #1076
@github-project-automation github-project-automation bot moved this from Under review to Done in A+ sprints Oct 17, 2023
markkuriekkinen pushed a commit to markkuriekkinen/a-plus that referenced this issue Oct 17, 2023
@ihalaij1 @markkuriekkinen
Support disabling duplicate submission check
f864a85 
Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Fixes apluslms#1076
murhum1 pushed a commit to murhum1/a-plus that referenced this issue Dec 21, 2023
@ihalaij1 @rkdarst
Support disabling duplicate submission check
d255caa 
Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Fixes apluslms#1076
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@ihalaij1
Support disabling duplicate submission check
425f0be 
Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Fixes apluslms#1076
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@ihalaij1
Support disabling duplicate submission check
45deeb3 
Some exercises often expect the submissions to be identical,
so always showing the confirmation dialog is unnecessary.

Fixes apluslms#1076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihalaij1 ihalaij1

Labels
area: UX student User experience and usability for students effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requester: CS The issue is raised internally by a CS teacher requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: bug This is a bug
Projects
A+ sprints
Status: Done
Milestone
v1.20.X patches in the autumn 2023
Development

Successfully merging a pull request may close this issue.

Support disabling duplicate submission check ihalaij1/a-plus
3 participants
@markkuriekkinen @jykesaviaGNH @ihalaij1