LTI Tool: Problems with submission received view #1114
Assignees
Labels
area: LTI
LTI protocol (Learning Tools Interoperability, worldwide standard)
requester: team
The issue is raised by a person inside the A+ developer team
type: bug
This is a bug
Milestone
Comments
PasiSa
added
type: bug
PasiSa
changed the title
|
This issue is also listed in this comment:
|
EerikSaksi
added a commit
to EerikSaksi/a-plus
that referenced
this issue
Feb 15, 2023
markkuriekkinen
added a commit
to markkuriekkinen/a-plus
that referenced
this issue
May 19, 2023
The A+ LTI Tool v1.3 (apluslms#1104) implementation broke the polling of the submission feedback in full-view exercise pages. The polling was also broken in the LTI exercise full-view pages. Remove the URL `lti-submission-poll` because it used the same view as the normal `submission-poll` URL. The template `_lti_exercise_wait.html` is not needed since it was a copy of `_exercise_wait.html` with a different poll URL. The template block `exercise_wait` is now unnecessary. It was added in apluslms#1104. Adding the block was a mistake originally since the parent templates did not have such a block and it basically did not render anything. The block `exercise_wait` was not part of any existing block. The template `lti_submission.html` should not override the block `exerciseinfo`. It was copied from `submission.html` and the submission info page was thus rendered twice in the LTI submission page. Fixes apluslms#1114 Closes apluslms#1162
markkuriekkinen
added a commit
to markkuriekkinen/a-plus
that referenced
this issue
Jun 2, 2023
The A+ LTI Tool v1.3 (apluslms#1104) implementation broke the polling of the submission feedback in full-view exercise pages. The polling was also broken in the LTI exercise full-view pages. Remove the URL `lti-submission-poll` because it used the same view as the normal `submission-poll` URL. The template `_lti_exercise_wait.html` is not needed since it was a copy of `_exercise_wait.html` with a different poll URL. Poll.js is changed so that the final target URL can be configured through HTML data attributes. Previously, poll.js had a hardcoded assumption that the final target URL could be derived from the poll URL by dropping the word "poll" from the end of the poll URL. That was not flexible enough for LTI Tool URLs that start with the "/lti" prefix. The template block `exercise_wait` is now unnecessary. It was added in apluslms#1104. Adding the block was a mistake originally since the parent templates did not have such a block and it basically did not render anything. The block `exercise_wait` was not part of any existing block. The template `lti_submission.html` should not override the block `exerciseinfo`. It was copied from `submission.html` and the submission info page was thus rendered twice in the LTI submission page. Fixes apluslms#1114 Closes apluslms#1162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running an A+ task as LTI activity from MyCourses, after submitting solution to a task, "Submission received ... Your submission is being graded ..." is shown, but the view is not refreshed to show the submission result after grading completes. Also the "Submission Info" box is shown two times on right, once is enough.
The text was updated successfully, but these errors were encountered: