New course instance copies the SIS id from the old instance if no new SIS id is set

[markkuriekkinen]

When a teacher creates a new course instance under the Edit course - Instances page, it is possible that the new course instance copies the SIS id and enroll settings from the old course instance. This means that the students registered to the old course in SISU are also added to the new A+ course instance, which is absolutely not wanted. The old SIS id is copied to the new course if the teacher does not select anything in the SIS fields on the CloneInstanceForm. This is actually common since the SIS course ids are usually not yet available, e.g., in May for the coming autumn courses.

The new A+ course instance should have an empty SIS id after creation if the teacher has not selected any new SIS id in the CloneInstanceForm.

Currently, the code sets a new SIS id only when the teacher has selected something in the form:

a-plus/edit_course/operations/clone.py

Lines 93 to 94 in 2a339fc

	if siskey and siskey != 'none':
	set_sis(instance, siskey, sisenroll)

[ihalaij1]

I'm pretty sure the fix is to set instance.sis_id = '' and instance.sis_enroll = False in clone.py before instance.save() is called.

[PasiSa]

I'm pretty sure the fix is to set instance.sis_id = '' and instance.sis_enroll = False in clone.py before instance.save() is called.

Yep, correct. I can push the fix shortly.

[markkuriekkinen]

@PasiSa
8ab057c

    instance.sis_id =''
    instance.sis_enroll = False

Unfortunate whitespace mistake: missing whitespace after =
sis_id =''