Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exercise_accessible and is_revealed #1242

Open
lainets opened this issue Sep 1, 2023 · 0 comments
Open

Refactor exercise_accessible and is_revealed #1242

lainets opened this issue Sep 1, 2023 · 0 comments
Labels
effort: days Estimated to take less than one week, from the creation of a new branch to the merging requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: refactoring Refactoring of code without changing features

Comments

@lainets
Copy link
Contributor

lainets commented Sep 1, 2023

The exercise_accessible tag should be refactored to work similarly to the is_listed and is_visible tags (or later methods with the new cache changes). This means saving whether it is accessible to the cache (or saving enough data to the cache to easily compute whether it is accessible) and checking that instead of computing the value in the templatetag file exercise/templatetags/exercise.py. As part of this refactoring, the is_revealed attribute (in CachedPoints) should be taken into account in whether it is accessible, and the is_revealed checks can be removed from the HTML files.

@lainets lainets added type: refactoring Refactoring of code without changing features effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: beginner required knowledge estimate requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) labels Sep 1, 2023
@PasiSa PasiSa moved this to Todo in A+ sprints Sep 6, 2023
@PasiSa PasiSa removed the experience: beginner required knowledge estimate label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: days Estimated to take less than one week, from the creation of a new branch to the merging requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: refactoring Refactoring of code without changing features
Projects
Status: Todo
Development

No branches or pull requests

2 participants