Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapters the user has no access to are included in the next/previous links #1249

Closed
lainets opened this issue Sep 1, 2023 · 1 comment
Closed

Chapters the user has no access to are included in the next/previous links #1249

lainets opened this issue Sep 1, 2023 · 1 comment
Assignees
@PasiSa
Labels
area: navigation Issues related to menus and navigation effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: feature New feature or change to a feature
Milestone
v1.20 - Summer 2023

Comments

@lainets
Copy link
Contributor

lainets commented Sep 1, 2023

Chapter pages contain links to the next and previous chapter at the top of the chapter content. If the previous or next chapter is a chapter the user doesn't have access to (e.g. a module model solution chapter whose module hasn't been passed), the link to that is shown but clicking on it will cause a 403 page (or a login screen if not logged in) to be shown. This page also does not contain any links back to the course pages or where you came from.

How to fix this isn't clear, and any implementation probably wont be easy.

This was mentioned by @jsorva in #1247. Some solutions to this issue may fix that issue as well.
@lainets lainets added type: feature New feature or change to a feature area: navigation Issues related to menus and navigation effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) labels Sep 1, 2023
@PasiSa PasiSa moved this to Todo in A+ sprints Sep 6, 2023
@PasiSa
Copy link
Contributor

PasiSa commented Sep 13, 2023

There was a related bug #1266 with opposite problem: In module view the content chapters were incorrectly hidden due to recent reveal rule changes for model solution chapters (which affects all courses). It seems that the _siblings.html template was forgotten to be updated in the similar way as the _children.html was. Issues #1242 and #1243 are also very much related.

@PasiSa PasiSa mentioned this issue Sep 13, 2023
Open
@PasiSa PasiSa self-assigned this Sep 18, 2023
@PasiSa PasiSa moved this from Todo to In Progress in A+ sprints Sep 18, 2023
PasiSa added a commit to PasiSa/a-plus that referenced this issue Sep 18, 2023
@PasiSa
Check if next/prev navigation link can be revealed
bbedb39 
Recently added changes for reveal rules on model solution chapters had
forgot to add the needed checks in _siblings.html
Fixes apluslms#1249
@PasiSa PasiSa moved this from In Progress to Under review in A+ sprints Sep 18, 2023
PasiSa added a commit to PasiSa/a-plus that referenced this issue Sep 18, 2023
@PasiSa
Check if next/prev navigation link can be revealed
26c73d7 
Recently added changes for reveal rules on model solution chapters had
forgot to add the needed checks in _siblings.html
Fixes apluslms#1249
@github-project-automation github-project-automation bot moved this from Under review to Done in A+ sprints Sep 19, 2023
@markkuriekkinen markkuriekkinen added this to the v1.20 - Summer 2023 milestone Sep 19, 2023
@markkuriekkinen markkuriekkinen mentioned this issue Oct 19, 2023
Merged
18 tasks
murhum1 pushed a commit to murhum1/a-plus that referenced this issue Dec 21, 2023
@PasiSa @rkdarst
Check if next/prev navigation link can be revealed
4f2e2cf 
Recently added changes for reveal rules on model solution chapters had
forgot to add the needed checks in _siblings.html
Fixes apluslms#1249
ihalaij1 pushed a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@PasiSa @ihalaij1
Check if next/prev navigation link can be revealed
28140c9 
Recently added changes for reveal rules on model solution chapters had
forgot to add the needed checks in _siblings.html
Fixes apluslms#1249
ihalaij1 pushed a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@PasiSa @ihalaij1
Check if next/prev navigation link can be revealed
b179906 
Recently added changes for reveal rules on model solution chapters had
forgot to add the needed checks in _siblings.html
Fixes apluslms#1249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PasiSa PasiSa

Labels
area: navigation Issues related to menus and navigation effort: days Estimated to take less than one week, from the creation of a new branch to the merging experience: moderate required knowledge estimate requires: priority Currently using this label to flag issues that need EDIT decision ASAP (even if there was priority) type: feature New feature or change to a feature
Projects
A+ sprints
Status: Done
Milestone
v1.20 - Summer 2023
Development

No branches or pull requests
3 participants
@PasiSa @markkuriekkinen @lainets