Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include navigation links in LTI views #1239

Open
PasiSa opened this issue Aug 30, 2023 · 2 comments · Fixed by #1290
Open

Include navigation links in LTI views #1239

PasiSa opened this issue Aug 30, 2023 · 2 comments · Fixed by #1290
Assignees
@PasiSa
Labels
area: LTI LTI protocol (Learning Tools Interoperability, worldwide standard) area: navigation Issues related to menus and navigation effort: hours Estimated to take less than one day, from the creation of a new branch to the merging requester: CS The issue is raised internally by a CS teacher type: feature New feature or change to a feature
Milestone
v1.20.X patches i...

Comments

@PasiSa
Copy link
Contributor

PasiSa commented Aug 30, 2023

When A+ content is opened from external LTI 1.3 platform, the view does not show the usual navigation links to move between chapters. When LTI is used to access a full course, or a module, the usual direct navigation links would be desired.

When LTI is used to access a single exercise, not showing the navigation links is probably ok, though, so that user does not start wandering to unintended places. Not sure if it is possible to distinguish these different use cases.
@PasiSa PasiSa added type: feature New feature or change to a feature area: LTI LTI protocol (Learning Tools Interoperability, worldwide standard) area: navigation Issues related to menus and navigation effort: hours Estimated to take less than one day, from the creation of a new branch to the merging labels Aug 30, 2023
@PasiSa PasiSa self-assigned this Aug 30, 2023
@PasiSa PasiSa added the requester: CS The issue is raised internally by a CS teacher label Aug 30, 2023
@PasiSa PasiSa moved this to Todo in A+ sprints Sep 6, 2023
@PasiSa PasiSa moved this from Todo to In Progress in A+ sprints Sep 8, 2023
@PasiSa
Copy link
Contributor Author

PasiSa commented Sep 13, 2023

This is well in progress, but currently on a short hold, until we have fixed related issues #1266 and #1249 .

@markkuriekkinen markkuriekkinen added this to the v1.20 - Summer 2023 milestone Sep 19, 2023
PasiSa added a commit to PasiSa/a-plus that referenced this issue Sep 27, 2023
@PasiSa
Enable navigation between pages also with LTI

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
bd597ee 
The HTML templates in LTI Tool implementation did not show the
navigation links to previous and next page. Now they are visible again.

Closes apluslms#1239
PasiSa added a commit to PasiSa/a-plus that referenced this issue Sep 27, 2023
@PasiSa
Enable navigation between pages also with LTI
b767867 
The HTML templates in LTI Tool implementation did not show the
navigation links to previous and next page. Now they are visible again.

Closes apluslms#1239
@markkuriekkinen markkuriekkinen linked a pull request Oct 19, 2023 that will close this issue
Make navigation links visible in LTI tool #1290
Merged
18 tasks
markkuriekkinen pushed a commit to PasiSa/a-plus that referenced this issue Oct 20, 2023
@PasiSa @markkuriekkinen
Enable navigation between pages also with LTI
b88668d 
The HTML templates in LTI Tool implementation did not show the
navigation links to previous and next page. Now they are visible again.

Closes apluslms#1239
markkuriekkinen added a commit to PasiSa/a-plus that referenced this issue Oct 20, 2023
@markkuriekkinen
Fix bugs in the LTI Tool views' course content links
3bd1d06 
The LTI course view and module view had wrong links to
the course contents: the links pointed to the normal views
instead of the LTI versions of the views.

There was a crash in the LTI exercise view: `upper_name` and
`upper_link` variables were used when they were not defined at all.

Related to apluslms#1239 and apluslms#1290
markkuriekkinen pushed a commit that referenced this issue Oct 20, 2023
@PasiSa @markkuriekkinen
Enable navigation between pages also with LTI
e5c63f5 
The HTML templates in LTI Tool implementation did not show the
navigation links to previous and next page. Now they are visible again.

Closes #1239
markkuriekkinen added a commit that referenced this issue Oct 20, 2023
@markkuriekkinen
Fix bugs in the LTI Tool views' course content links
111e551 
The LTI course view and module view had wrong links to
the course contents: the links pointed to the normal views
instead of the LTI versions of the views.

There was a crash in the LTI exercise view: `upper_name` and
`upper_link` variables were used when they were not defined at all.

Related to #1239 and #1290
@markkuriekkinen
Copy link
Contributor

#1290 fixes this issue in the v1.20_stable branch, but the fix needs to be ported to the master branch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PasiSa PasiSa

Labels
area: LTI LTI protocol (Learning Tools Interoperability, worldwide standard) area: navigation Issues related to menus and navigation effort: hours Estimated to take less than one day, from the creation of a new branch to the merging requester: CS The issue is raised internally by a CS teacher type: feature New feature or change to a feature
Projects
A+ sprints
Status: In Progress
Milestone
v1.20.X patches in the autumn 2023
Development

Successfully merging a pull request may close this issue.

Make navigation links visible in LTI tool PasiSa/a-plus
2 participants
@PasiSa @markkuriekkinen