Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The All Results page describes missing student IDs as "null" #1272

Closed
jsorva opened this issue Sep 15, 2023 · 3 comments · Fixed by #1284
Closed

The All Results page describes missing student IDs as "null" #1272

jsorva opened this issue Sep 15, 2023 · 3 comments · Fixed by #1284
Assignees
@ashi006
Labels
area: accessibility Related to accessibility, e.g., accessibility standards and guidelines area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers O1 needs Requested in the Programming 1 course requester: CS The issue is raised internally by a CS teacher type: feature New feature or change to a feature
Milestone
v1.20.X patches i...

Comments

@jsorva
Copy link

jsorva commented Sep 15, 2023 •
edited
Loading

My Gmail test account now shows up on the "All Results" page as shown below — as do various student accounts. "null" isn’t the best user-facing string. (This is not very important, since it’s only teachers that see this, I presume.)

image
@markkuriekkinen
Copy link
Contributor

MOOC students don't have student ids, thus the value is missing. The "All results" table uses the word null in this case, but sure, the word could be changed.

It has been like this for a long time. This is not a new change.

@markkuriekkinen markkuriekkinen added type: feature New feature or change to a feature area: user interface User interface issues that are not specifically about navigation or user experience (UX) O1 needs Requested in the Programming 1 course effort: hours Estimated to take less than one day, from the creation of a new branch to the merging area: accessibility Related to accessibility, e.g., accessibility standards and guidelines experience: beginner required knowledge estimate requester: CS The issue is raised internally by a CS teacher labels Sep 15, 2023
@jsorva jsorva changed the title The All Results page shows "null" The All Results page describes missing student IDs as "null" Sep 15, 2023
@PasiSa PasiSa added experience: good first issue Good for newcomers and removed experience: beginner required knowledge estimate labels Oct 3, 2023
@PasiSa PasiSa moved this to Todo in A+ sprints Oct 10, 2023
@ashi006
Copy link
Contributor

ashi006 commented Oct 10, 2023

@jsorva would the hyphen "-" be a good replacement for null or should we leave it empty?

@jsorva
Copy link
Author

jsorva commented Oct 10, 2023

@jsorva would the hyphen "-" be a good replacement for null or should we leave it empty?

Hi! I don’t have strong opinions about this. I’d probably put either a dash, like you suggest, or a string like "none" or "n/a". If you go with a dash, an em dash (—) would be more appropriate than a hyphen.

@markkuriekkinen markkuriekkinen added this to the v1.21 milestone Oct 10, 2023
@markkuriekkinen markkuriekkinen moved this from Todo to In Progress in A+ sprints Oct 10, 2023
@ashi006 ashi006 mentioned this issue Oct 11, 2023
Merged
18 tasks
@ashi006 ashi006 moved this from In Progress to Under review in A+ sprints Oct 11, 2023
ashi006 added a commit to ashi006/a-plus that referenced this issue Oct 13, 2023
@ashi006
Change null to mdash on empty student ids in the All results table
46a5007 
Fixes apluslms#1272
markkuriekkinen pushed a commit that referenced this issue Oct 17, 2023
@ashi006 @markkuriekkinen
Change null to mdash on empty student ids in the All results table
9838b02 
Fixes #1272
@github-project-automation github-project-automation bot moved this from Under review to Done in A+ sprints Oct 17, 2023
markkuriekkinen pushed a commit that referenced this issue Oct 17, 2023
@ashi006 @markkuriekkinen
Change null to mdash on empty student ids in the All results table
6a57c28 
Fixes #1272
murhum1 pushed a commit to murhum1/a-plus that referenced this issue Dec 21, 2023
@ashi006 @rkdarst
Change null to mdash on empty student ids in the All results table
6cbf56b 
Fixes apluslms#1272
ihalaij1 pushed a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@ashi006 @ihalaij1
Change null to mdash on empty student ids in the All results table
6bca490 
Fixes apluslms#1272
ihalaij1 pushed a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@ashi006 @ihalaij1
Change null to mdash on empty student ids in the All results table
bb35b1c 
Fixes apluslms#1272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashi006 ashi006

Labels
area: accessibility Related to accessibility, e.g., accessibility standards and guidelines area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: good first issue Good for newcomers O1 needs Requested in the Programming 1 course requester: CS The issue is raised internally by a CS teacher type: feature New feature or change to a feature
Projects
A+ sprints
Status: Done
Milestone
v1.20.X patches in the autumn 2023
Development

Successfully merging a pull request may close this issue.

Change null to mdash on empty student ids in the All results table ashi006/a-plus
4 participants
@PasiSa @markkuriekkinen @jsorva @ashi006