Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The word wrap button doesn’t work when inspecting student submissions #1281

Closed
jsorva opened this issue Oct 6, 2023 · 3 comments · Fixed by #1286
Closed

The word wrap button doesn’t work when inspecting student submissions #1281

jsorva opened this issue Oct 6, 2023 · 3 comments · Fixed by #1286
Assignees
@ihalaij1
Labels
area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate O1 needs Requested in the Programming 1 course requester: CS The issue is raised internally by a CS teacher type: bug This is a bug
Milestone
v1.20.X patches i...

Comments

@jsorva
Copy link

jsorva commented Oct 6, 2023 •
edited
Loading

When inspecting student submissions, these buttons are shown:

image

However, the Word wrap button fails to work, and produces this in the Console:

image

I’ve also had difficulties with the Copy to clipboard button in the same view but that may be related to the specifics of my own setup, so if it seems to work for everyone else, maybe the problem is at my end.
@jsorva jsorva changed the title UI buttons don’t work when inspecting student submissions The word wrap button doesn’t work when inspecting student submissions Oct 6, 2023
@markkuriekkinen markkuriekkinen added type: bug This is a bug area: user interface User interface issues that are not specifically about navigation or user experience (UX) O1 needs Requested in the Programming 1 course effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate requester: CS The issue is raised internally by a CS teacher labels Oct 10, 2023
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Oct 12, 2023
@ihalaij1
Load long feedback and submission/template/model files in chunks
2c66e2b 
Loading extremely long submission/template/model files and feedback
was made faster in apluslms#1260 by omitting the line numbers if the data
was longer than 5000 lines.

The performance is now improved even more by utilizing document
fragments and chunked loading, where the user can press a button
to load the next 5000 lines (with line numbers always included).

This fixes a potential 'Out of memory' browser error and a bug
where the word wrap button was not working.

Fixes apluslms#1281
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Oct 12, 2023
@ihalaij1
Load long feedback and submission/template/model files in chunks
56b9bc9 
Loading extremely long submission/template/model files and feedback
was made faster in apluslms#1260 by omitting the line numbers if the data
was longer than 5000 lines.

The performance is now improved even more by utilizing document
fragments and chunked loading, where the user can press a button
to load the next 5000 lines (with line numbers always included).

This fixes a potential 'Out of memory' browser error and a bug
where the word wrap button was not working.

Fixes apluslms#1281
@ihalaij1 ihalaij1 mentioned this issue Oct 12, 2023
Merged
18 tasks
@ihalaij1 ihalaij1 moved this from Todo to Under review in A+ sprints Oct 12, 2023
@ihalaij1 ihalaij1 self-assigned this Oct 12, 2023
@markkuriekkinen
Copy link
Contributor

There is another report of the broken "word wrap" button in the internal ticket system:
https://rt.cs.aalto.fi/Ticket/Display.html?id=24561

ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Oct 18, 2023
@ihalaij1
Fix word wrap button not working on inspect submission page
151271a 
Fixes apluslms#1281
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Oct 18, 2023
@ihalaij1
Fix word wrap button not working on inspect submission page
fa680b2 
Fixes apluslms#1281
@github-project-automation github-project-automation bot moved this from Under review to Done in A+ sprints Oct 23, 2023
markkuriekkinen pushed a commit to markkuriekkinen/a-plus that referenced this issue Oct 23, 2023
@ihalaij1 @markkuriekkinen
Fix word wrap button not working on inspect submission page
851dc29 
Fixes apluslms#1281
@markkuriekkinen
Copy link
Contributor

@jsorva about the "copy to clipboard" button, I haven't seen issues in it. The "word wrap" button has been fixed.

@jsorva
Copy link
Author

jsorva commented Oct 24, 2023

OK. After hearing another comment from a student, I’m reasonably sure that that symptom — experienced by me and this student — has to do with pasting into IntelliJ IDEA and is not related to A+. Please ignore that part of this issue. Thanks for confirming!

murhum1 pushed a commit to murhum1/a-plus that referenced this issue Dec 21, 2023
@ihalaij1 @rkdarst
Fix word wrap button not working on inspect submission page
b29780c 
Fixes apluslms#1281
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@ihalaij1
Fix word wrap button not working on inspect submission page
47c7865 
Fixes apluslms#1281
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@ihalaij1
Fix word wrap button not working on inspect submission page
5c1f63e 
Fixes apluslms#1281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihalaij1 ihalaij1

Labels
area: user interface User interface issues that are not specifically about navigation or user experience (UX) effort: hours Estimated to take less than one day, from the creation of a new branch to the merging experience: beginner required knowledge estimate O1 needs Requested in the Programming 1 course requester: CS The issue is raised internally by a CS teacher type: bug This is a bug
Projects
A+ sprints
Status: Done
Milestone
v1.20.X patches in the autumn 2023
Development

Successfully merging a pull request may close this issue.

Add scroll separately button for submitted files on inspect page ihalaij1/a-plus
3 participants
@markkuriekkinen @jsorva @ihalaij1