Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binaryornot library sometimes incorrectly classifies PDF files as non-binary #1298

Closed
ihalaij1 opened this issue Oct 27, 2023 · 0 comments · Fixed by #1299
Closed

Binaryornot library sometimes incorrectly classifies PDF files as non-binary #1298

ihalaij1 opened this issue Oct 27, 2023 · 0 comments · Fixed by #1299
Assignees
@ihalaij1
Labels
area: performance Related to the performance of the system type: bug This is a bug
Milestone
v1.20.X patches i...

Comments

@ihalaij1
Copy link
Contributor

When large PDF files are detected as non-binary data, the inspect submission page tries to render them and causes the page to load slowly.
@ihalaij1 ihalaij1 added type: bug This is a bug area: performance Related to the performance of the system labels Oct 27, 2023
@ihalaij1 ihalaij1 self-assigned this Oct 27, 2023
@ihalaij1 ihalaij1 moved this to Under review in A+ sprints Oct 27, 2023
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Oct 27, 2023
@ihalaij1
Always classify files ending with '.pdf' as non-binary
4e8ae64 
When a student submitted a large PDF file and it was incorrectly
detected as non-binary data by the binaryornot library, the inspect
submission page tried to render it and caused the page to load slowly.

Fixes apluslms#1298
@ihalaij1 ihalaij1 mentioned this issue Oct 27, 2023
Merged
markkuriekkinen pushed a commit to ihalaij1/a-plus that referenced this issue Oct 28, 2023
@ihalaij1 @markkuriekkinen
Always classify files ending with '.pdf' as binary
be04150 
When a student submitted a large PDF file and it was incorrectly
detected as non-binary (plain text) data by the binaryornot library,
the inspect submission page tried to render a preview of the file.
It caused the page to load slowly.

Fixes apluslms#1298
markkuriekkinen pushed a commit that referenced this issue Oct 28, 2023
@ihalaij1 @markkuriekkinen
Always classify files ending with '.pdf' as binary
b4d89cf 
When a student submitted a large PDF file and it was incorrectly
detected as non-binary (plain text) data by the binaryornot library,
the inspect submission page tried to render a preview of the file.
It caused the page to load slowly.

Fixes #1298
@github-project-automation github-project-automation bot moved this from Under review to Done in A+ sprints Oct 28, 2023
markkuriekkinen pushed a commit to markkuriekkinen/a-plus that referenced this issue Oct 28, 2023
@ihalaij1 @markkuriekkinen
Always classify files ending with '.pdf' as binary
02c0b50 
When a student submitted a large PDF file and it was incorrectly
detected as non-binary (plain text) data by the binaryornot library,
the inspect submission page tried to render a preview of the file.
It caused the page to load slowly.

Fixes apluslms#1298
murhum1 pushed a commit to murhum1/a-plus that referenced this issue Dec 21, 2023
@ihalaij1 @rkdarst
Always classify files ending with '.pdf' as binary
82226db 
When a student submitted a large PDF file and it was incorrectly
detected as non-binary (plain text) data by the binaryornot library,
the inspect submission page tried to render a preview of the file.
It caused the page to load slowly.

Fixes apluslms#1298
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@ihalaij1
Always classify files ending with '.pdf' as binary
b9f8e3d 
When a student submitted a large PDF file and it was incorrectly
detected as non-binary (plain text) data by the binaryornot library,
the inspect submission page tried to render a preview of the file.
It caused the page to load slowly.

Fixes apluslms#1298
ihalaij1 added a commit to ihalaij1/a-plus that referenced this issue Dec 22, 2023
@ihalaij1
Always classify files ending with '.pdf' as binary
61dc720 
When a student submitted a large PDF file and it was incorrectly
detected as non-binary (plain text) data by the binaryornot library,
the inspect submission page tried to render a preview of the file.
It caused the page to load slowly.

Fixes apluslms#1298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihalaij1 ihalaij1

Labels
area: performance Related to the performance of the system type: bug This is a bug
Projects
A+ sprints
Status: Done
Milestone
v1.20.X patches in the autumn 2023
Development

Successfully merging a pull request may close this issue.

Always classify files ending with '.pdf' as binary ihalaij1/a-plus
2 participants
@markkuriekkinen @ihalaij1