Improve logging and output on SIS interactions #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show also the number of removed students in log and UI notification. If error occurs, show the course that was being fetched. Closes apluslms#1157
PasiSa
force-pushed
the
better_sis_logging
branch
from
c1cc2b3 to
8d529c4
Compare
markkuriekkinen
approved these changes
Feb 3, 2023
| ), | ||
| count=count, | ||
| addcount=addcount, | ||
| ) + " " + format_lazy( |
There was a problem hiding this comment.
Concatenating translated strings with a space could maybe cause trouble with non-western languages that use right-to-left or top-to-bottom script, but let's ignore those now.
An alternative could be to render the two sentences in different paragraphs in the HTML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show also the number of removed students in log and UI notification. If error occurs, show the course that was being fetched.
Closes #1157
Description
What?
[ANSWER HERE]
Why?
[ANSWER HERE]
How?
[ANSWER HERE]
Fixes #
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!